eeprom params for ice1724 module - recommendation?

eeprom params for ice1724 module - recommendation?

[Pavel Hofman]

Hi,

I have a generic ice1724 card ooAoo SQ210a (e.g.
http://forum.lowyat.net/topic/851912/all ). The card has identical PCI
identification with Chaintec AV710, no DAC controls (the DAC is
hardwired in pin-control mode with no GPIOs attached), no identification
string in eeprom and of course incorrect eeprom values.

Since the PCI ids overlap with the Chaintec, I cannot define correct
eeprom_data for this specific card in the driver. Furthermore I would
not be surprised if the other ooAoo cards with different setups shared
the same PCI ids.

I can skip the Chaintec config by specifying an unknown model in
snd-ice1724 param, e.g.

modprobe snd-ice1724 model=aooa

I would like to be able to specify correct eeprom values for the model
too. That would be simple by adding several new module params -
eeep2-sysconf, eeep2-aclink, eeep2-spdif etc.

However, I have another ice1724 card properly supported by the driver
(Infrasonic Quartet). I can use

modprobe snd-ice1724 model=quartet,aooa

and everything works correctly. But if I wanted to define eeep2-xxx
params for the aooa, I would have to define the same params for the
quartet too which I find superfluous since they are already correctly in
the driver.

Or I could use a string type instead of int and use something like

eeep2-sysconf=default,47

Or I could "encode" the eeep2 params into the model name, such as

modprobe snd-ice1724 model="quartet,aooa(eeep2-sysconf=47;eeep2-spdif=20)"

Please which version would you recommend (i.e. accept as a patch)?

Thank you for your expert advice.

Best regards,

Pavel.

Re: eeprom params for ice1724 module - recommendation?

[Pavel Hofman]

Dne 4.1.2012 21:37, Pavel Hofman napsal(a):
> Hi,
> 
> Please which version would you recommend (i.e. accept as a patch)?
> 

I think there is a much better option - defining the eeprom values for
this card in the driver and choosing it with the model name. I will send
the patch.

Regards,

Pavel.

Re: eeprom params for ice1724 module

[Pavel Hofman]

Dne 4.1.2012 23:30, Pavel Hofman napsal(a):
> Dne 4.1.2012 21:37, Pavel Hofman napsal(a):
> 
> I think there is a much better option - defining the eeprom values for
> this card in the driver and choosing it with the model name. I will send
> the patch.
> 

The patches allowing the above plus the actual config follow. I have put
the card definition directly into ice1724.c since it is rather short. I
can store it in a separate file should you find it necessary.

Thanks a lot and best regards,

Pavel.