* [PATCH 1/2] usb: renesas_usbhs: add IRQ resource decoding for
@ 2012-01-05 5:13 Shimoda, Yoshihiro
2012-01-05 5:31 ` [PATCH 1/2] usb: renesas_usbhs: add IRQ resource decoding for IRQF_SHARED Kuninori Morimoto
2012-01-05 5:57 ` [PATCH 1/2] usb: renesas_usbhs: add IRQ resource decoding for Shimoda, Yoshihiro
0 siblings, 2 replies; 3+ messages in thread
From: Shimoda, Yoshihiro @ 2012-01-05 5:13 UTC (permalink / raw)
To: linux-sh
Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
---
drivers/usb/renesas_usbhs/common.c | 11 ++++++-----
drivers/usb/renesas_usbhs/common.h | 1 +
drivers/usb/renesas_usbhs/mod.c | 2 +-
3 files changed, 8 insertions(+), 6 deletions(-)
diff --git a/drivers/usb/renesas_usbhs/common.c b/drivers/usb/renesas_usbhs/common.c
index 08c679c..75f7d08 100644
--- a/drivers/usb/renesas_usbhs/common.c
+++ b/drivers/usb/renesas_usbhs/common.c
@@ -410,8 +410,7 @@ static int usbhs_probe(struct platform_device *pdev)
struct renesas_usbhs_platform_info *info = pdev->dev.platform_data;
struct renesas_usbhs_driver_callback *dfunc;
struct usbhs_priv *priv;
- struct resource *res;
- unsigned int irq;
+ struct resource *res, *irq_res;
int ret;
/* check platform information */
@@ -423,8 +422,8 @@ static int usbhs_probe(struct platform_device *pdev)
/* platform data */
res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- irq = platform_get_irq(pdev, 0);
- if (!res || (int)irq <= 0) {
+ irq_res = platform_get_resource(pdev, IORESOURCE_IRQ, 0);
+ if (!res || !irq_res) {
dev_err(&pdev->dev, "Not enough Renesas USB platform resources.\n");
return -ENODEV;
}
@@ -473,7 +472,9 @@ static int usbhs_probe(struct platform_device *pdev)
/*
* priv settings
*/
- priv->irq = irq;
+ priv->irq = irq_res->start;
+ if (irq_res->flags & IORESOURCE_IRQ_SHAREABLE)
+ priv->irqflags = IRQF_SHARED;
priv->pdev = pdev;
INIT_DELAYED_WORK(&priv->notify_hotplug_work, usbhsc_notify_hotplug);
spin_lock_init(usbhs_priv_to_lock(priv));
diff --git a/drivers/usb/renesas_usbhs/common.h b/drivers/usb/renesas_usbhs/common.h
index 8729da5..353ab51 100644
--- a/drivers/usb/renesas_usbhs/common.h
+++ b/drivers/usb/renesas_usbhs/common.h
@@ -241,6 +241,7 @@ struct usbhs_priv {
void __iomem *base;
unsigned int irq;
+ unsigned long irqflags;
struct renesas_usbhs_platform_callback pfunc;
struct renesas_usbhs_driver_param dparam;
diff --git a/drivers/usb/renesas_usbhs/mod.c b/drivers/usb/renesas_usbhs/mod.c
index ad96a38..9499fae 100644
--- a/drivers/usb/renesas_usbhs/mod.c
+++ b/drivers/usb/renesas_usbhs/mod.c
@@ -150,7 +150,7 @@ int usbhs_mod_probe(struct usbhs_priv *priv)
/* irq settings */
ret = request_irq(priv->irq, usbhs_interrupt,
- 0, dev_name(dev), priv);
+ priv->irqflags, dev_name(dev), priv);
if (ret) {
dev_err(dev, "irq request err\n");
goto mod_init_gadget_err;
--
1.7.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH 1/2] usb: renesas_usbhs: add IRQ resource decoding for IRQF_SHARED
2012-01-05 5:13 [PATCH 1/2] usb: renesas_usbhs: add IRQ resource decoding for Shimoda, Yoshihiro
@ 2012-01-05 5:31 ` Kuninori Morimoto
2012-01-05 5:57 ` [PATCH 1/2] usb: renesas_usbhs: add IRQ resource decoding for Shimoda, Yoshihiro
1 sibling, 0 replies; 3+ messages in thread
From: Kuninori Morimoto @ 2012-01-05 5:31 UTC (permalink / raw)
To: linux-sh
Hi Shimoda-san
Thank you for your patch.
> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
> ---
> drivers/usb/renesas_usbhs/common.c | 11 ++++++-----
> drivers/usb/renesas_usbhs/common.h | 1 +
> drivers/usb/renesas_usbhs/mod.c | 2 +-
> 3 files changed, 8 insertions(+), 6 deletions(-)
Can you please add the reason why this IRQF_SHARED is needed on renesas_usbhs ?
Best regards
---
Kuninori Morimoto
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/2] usb: renesas_usbhs: add IRQ resource decoding for
2012-01-05 5:13 [PATCH 1/2] usb: renesas_usbhs: add IRQ resource decoding for Shimoda, Yoshihiro
2012-01-05 5:31 ` [PATCH 1/2] usb: renesas_usbhs: add IRQ resource decoding for IRQF_SHARED Kuninori Morimoto
@ 2012-01-05 5:57 ` Shimoda, Yoshihiro
1 sibling, 0 replies; 3+ messages in thread
From: Shimoda, Yoshihiro @ 2012-01-05 5:57 UTC (permalink / raw)
To: linux-sh
Hi Morimoto-san,
Thank you for your comment.
2012/01/05 14:31, Kuninori Morimoto wrote:
>
> Hi Shimoda-san
>
> Can you please add the reason why this IRQF_SHARED is needed on renesas_usbhs ?
Yes. I will add the reason and submit the patch again.
Best regards,
Yoshihiro Shimoda
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-01-05 5:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-01-05 5:13 [PATCH 1/2] usb: renesas_usbhs: add IRQ resource decoding for Shimoda, Yoshihiro
2012-01-05 5:31 ` [PATCH 1/2] usb: renesas_usbhs: add IRQ resource decoding for IRQF_SHARED Kuninori Morimoto
2012-01-05 5:57 ` [PATCH 1/2] usb: renesas_usbhs: add IRQ resource decoding for Shimoda, Yoshihiro
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.