* [PATCH] mmc: dw_mmc: fixed wrong bit operation for SDMMC_GET_FCNT()
@ 2012-01-05 10:12 Jaehoon Chung
2012-01-05 10:20 ` Will Newton
0 siblings, 1 reply; 3+ messages in thread
From: Jaehoon Chung @ 2012-01-05 10:12 UTC (permalink / raw)
To: linux-mmc; +Cc: Chris Ball, Will Newton, James Hogan, Kyungmin Park
In status register, fifo_count is bit[29:17].
(0x1FFF is correctly)
Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
---
drivers/mmc/host/dw_mmc.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/mmc/host/dw_mmc.h b/drivers/mmc/host/dw_mmc.h
index 72c071f..df392a1 100644
--- a/drivers/mmc/host/dw_mmc.h
+++ b/drivers/mmc/host/dw_mmc.h
@@ -126,7 +126,7 @@
#define SDMMC_CMD_RESP_EXP BIT(6)
#define SDMMC_CMD_INDX(n) ((n) & 0x1F)
/* Status register defines */
-#define SDMMC_GET_FCNT(x) (((x)>>17) & 0x1FF)
+#define SDMMC_GET_FCNT(x) (((x)>>17) & 0x1FFF)
/* Internal DMAC interrupt defines */
#define SDMMC_IDMAC_INT_AI BIT(9)
#define SDMMC_IDMAC_INT_NI BIT(8)
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] mmc: dw_mmc: fixed wrong bit operation for SDMMC_GET_FCNT()
2012-01-05 10:12 [PATCH] mmc: dw_mmc: fixed wrong bit operation for SDMMC_GET_FCNT() Jaehoon Chung
@ 2012-01-05 10:20 ` Will Newton
2012-01-05 15:33 ` Chris Ball
0 siblings, 1 reply; 3+ messages in thread
From: Will Newton @ 2012-01-05 10:20 UTC (permalink / raw)
To: Jaehoon Chung
Cc: linux-mmc, Chris Ball, Will Newton, James Hogan, Kyungmin Park
On Thu, Jan 5, 2012 at 10:12 AM, Jaehoon Chung <jh80.chung@samsung.com> wrote:
> In status register, fifo_count is bit[29:17].
> (0x1FFF is correctly)
>
> Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> ---
> drivers/mmc/host/dw_mmc.h | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
Good catch, thanks!
Acked-by: Will Newton <will.newton@imgtec.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mmc: dw_mmc: fixed wrong bit operation for SDMMC_GET_FCNT()
2012-01-05 10:20 ` Will Newton
@ 2012-01-05 15:33 ` Chris Ball
0 siblings, 0 replies; 3+ messages in thread
From: Chris Ball @ 2012-01-05 15:33 UTC (permalink / raw)
To: Will Newton
Cc: Jaehoon Chung, linux-mmc, Will Newton, James Hogan, Kyungmin Park
Hi,
On Thu, Jan 05 2012, Will Newton wrote:
> On Thu, Jan 5, 2012 at 10:12 AM, Jaehoon Chung <jh80.chung@samsung.com> wrote:
>> In status register, fifo_count is bit[29:17].
>> (0x1FFF is correctly)
>>
>> Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
>> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
>> ---
>> drivers/mmc/host/dw_mmc.h | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> Good catch, thanks!
>
> Acked-by: Will Newton <will.newton@imgtec.com>
Pushed to mmc-next for 3.3, thanks.
- Chris.
--
Chris Ball <cjb@laptop.org> <http://printf.net/>
One Laptop Per Child
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-01-05 15:34 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-01-05 10:12 [PATCH] mmc: dw_mmc: fixed wrong bit operation for SDMMC_GET_FCNT() Jaehoon Chung
2012-01-05 10:20 ` Will Newton
2012-01-05 15:33 ` Chris Ball
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.