From: nicolas.bertrand <nicolas.bertrand@linux.intel.com>
To: ofono@ofono.org
Subject: Re: [PATCH] udevng: use huaweicdma driver for olive V-ME101
Date: Thu, 05 Jan 2012 17:05:16 +0100 [thread overview]
Message-ID: <4F05CA3C.5090005@linux.intel.com> (raw)
In-Reply-To: <1325750613.6454.65.camel@aeonflux>
[-- Attachment #1: Type: text/plain, Size: 1483 bytes --]
Hi Marcel,
On 01/05/2012 09:03 AM, Marcel Holtmann wrote:
> Hi Nicolas,
>
>> plugins/udevng.c | 3 +--
>> 1 files changed, 1 insertions(+), 2 deletions(-)
>>
>> diff --git a/plugins/udevng.c b/plugins/udevng.c
>> index be87320..8d478cf 100644
>> --- a/plugins/udevng.c
>> +++ b/plugins/udevng.c
>> @@ -800,11 +800,10 @@ static struct {
>> { "hso", "hso" },
>> { "gobi", "qcserial" },
>> { "sierra", "sierra" },
>> - { "huawei", "option", "201e", "2009" },
>> + { "huaweicdma", "option", "201e", "2009" },
>> { "huawei", "cdc_ether", "12d1" },
>> { "huawei", "option", "12d1" },
>> { "huaweicdma", "option", "12d1", "140b" },
>> - { "huaweicdma", "option", "201e" },
>> { "speedupcdma","option", "1c9e", "9e00" },
>> { "speedup", "option", "1c9e" },
>> { "speedup", "option", "2020" },
>
> the commit message does not explain why you are removing huaweicdma in
> general for VID 0x201e.
I've removed the generic configuration of HAIER's modem (0x201e) since
there is only one product ID used for the moment by this vendor (seen in
the option driver).
Do I need to only use the generic configuration and removing the
specific one to the PID 2009 or either simply add this comment in the
commit message?
>
> Regards
>
> Marcel
>
>
> _______________________________________________
> ofono mailing list
> ofono(a)ofono.org
> http://lists.ofono.org/listinfo/ofono
>
--
regards,
Nico
next prev parent reply other threads:[~2012-01-05 16:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-18 12:27 [PATCH] udevng: use huaweicdma driver for olive V-ME101 Nicolas Bertrand
2012-01-05 2:28 ` Deng, Ying An
2012-01-05 8:03 ` Marcel Holtmann
2012-01-05 16:05 ` nicolas.bertrand [this message]
2012-01-05 19:17 ` Marcel Holtmann
2012-01-06 0:57 ` Deng, Ying An
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F05CA3C.5090005@linux.intel.com \
--to=nicolas.bertrand@linux.intel.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.