* [PATCH] udevng: use huaweicdma driver for olive V-ME101
@ 2011-11-18 12:27 Nicolas Bertrand
2012-01-05 2:28 ` Deng, Ying An
2012-01-05 8:03 ` Marcel Holtmann
0 siblings, 2 replies; 6+ messages in thread
From: Nicolas Bertrand @ 2011-11-18 12:27 UTC (permalink / raw)
To: ofono
[-- Attachment #1: Type: text/plain, Size: 727 bytes --]
---
plugins/udevng.c | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/plugins/udevng.c b/plugins/udevng.c
index be87320..8d478cf 100644
--- a/plugins/udevng.c
+++ b/plugins/udevng.c
@@ -800,11 +800,10 @@ static struct {
{ "hso", "hso" },
{ "gobi", "qcserial" },
{ "sierra", "sierra" },
- { "huawei", "option", "201e", "2009" },
+ { "huaweicdma", "option", "201e", "2009" },
{ "huawei", "cdc_ether", "12d1" },
{ "huawei", "option", "12d1" },
{ "huaweicdma", "option", "12d1", "140b" },
- { "huaweicdma", "option", "201e" },
{ "speedupcdma","option", "1c9e", "9e00" },
{ "speedup", "option", "1c9e" },
{ "speedup", "option", "2020" },
--
1.7.4.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* RE: [PATCH] udevng: use huaweicdma driver for olive V-ME101
2011-11-18 12:27 [PATCH] udevng: use huaweicdma driver for olive V-ME101 Nicolas Bertrand
@ 2012-01-05 2:28 ` Deng, Ying An
2012-01-05 8:03 ` Marcel Holtmann
1 sibling, 0 replies; 6+ messages in thread
From: Deng, Ying An @ 2012-01-05 2:28 UTC (permalink / raw)
To: ofono
[-- Attachment #1: Type: text/plain, Size: 1270 bytes --]
This patch has not been accepted on upstream, but it seriously impacts support to VM101 CDMA dongle.
Can anybody help?
>-----Original Message-----
>From: ofono-bounces(a)ofono.org [mailto:ofono-bounces(a)ofono.org] On Behalf
>Of Nicolas Bertrand
>Sent: Friday, November 18, 2011 8:28 PM
>To: ofono(a)ofono.org
>Subject: [PATCH] udevng: use huaweicdma driver for olive V-ME101
>
>---
> plugins/udevng.c | 3 +--
> 1 files changed, 1 insertions(+), 2 deletions(-)
>
>diff --git a/plugins/udevng.c b/plugins/udevng.c
>index be87320..8d478cf 100644
>--- a/plugins/udevng.c
>+++ b/plugins/udevng.c
>@@ -800,11 +800,10 @@ static struct {
> { "hso", "hso" },
> { "gobi", "qcserial" },
> { "sierra", "sierra" },
>- { "huawei", "option", "201e", "2009" },
>+ { "huaweicdma", "option", "201e", "2009" },
> { "huawei", "cdc_ether", "12d1" },
> { "huawei", "option", "12d1" },
> { "huaweicdma", "option", "12d1", "140b" },
>- { "huaweicdma", "option", "201e" },
> { "speedupcdma","option", "1c9e", "9e00" },
> { "speedup", "option", "1c9e" },
> { "speedup", "option", "2020" },
>--
>1.7.4.1
>
>_______________________________________________
>ofono mailing list
>ofono(a)ofono.org
>http://lists.ofono.org/listinfo/ofono
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] udevng: use huaweicdma driver for olive V-ME101
2011-11-18 12:27 [PATCH] udevng: use huaweicdma driver for olive V-ME101 Nicolas Bertrand
2012-01-05 2:28 ` Deng, Ying An
@ 2012-01-05 8:03 ` Marcel Holtmann
2012-01-05 16:05 ` nicolas.bertrand
1 sibling, 1 reply; 6+ messages in thread
From: Marcel Holtmann @ 2012-01-05 8:03 UTC (permalink / raw)
To: ofono
[-- Attachment #1: Type: text/plain, Size: 885 bytes --]
Hi Nicolas,
> plugins/udevng.c | 3 +--
> 1 files changed, 1 insertions(+), 2 deletions(-)
>
> diff --git a/plugins/udevng.c b/plugins/udevng.c
> index be87320..8d478cf 100644
> --- a/plugins/udevng.c
> +++ b/plugins/udevng.c
> @@ -800,11 +800,10 @@ static struct {
> { "hso", "hso" },
> { "gobi", "qcserial" },
> { "sierra", "sierra" },
> - { "huawei", "option", "201e", "2009" },
> + { "huaweicdma", "option", "201e", "2009" },
> { "huawei", "cdc_ether", "12d1" },
> { "huawei", "option", "12d1" },
> { "huaweicdma", "option", "12d1", "140b" },
> - { "huaweicdma", "option", "201e" },
> { "speedupcdma","option", "1c9e", "9e00" },
> { "speedup", "option", "1c9e" },
> { "speedup", "option", "2020" },
the commit message does not explain why you are removing huaweicdma in
general for VID 0x201e.
Regards
Marcel
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] udevng: use huaweicdma driver for olive V-ME101
2012-01-05 8:03 ` Marcel Holtmann
@ 2012-01-05 16:05 ` nicolas.bertrand
2012-01-05 19:17 ` Marcel Holtmann
2012-01-06 0:57 ` Deng, Ying An
0 siblings, 2 replies; 6+ messages in thread
From: nicolas.bertrand @ 2012-01-05 16:05 UTC (permalink / raw)
To: ofono
[-- Attachment #1: Type: text/plain, Size: 1483 bytes --]
Hi Marcel,
On 01/05/2012 09:03 AM, Marcel Holtmann wrote:
> Hi Nicolas,
>
>> plugins/udevng.c | 3 +--
>> 1 files changed, 1 insertions(+), 2 deletions(-)
>>
>> diff --git a/plugins/udevng.c b/plugins/udevng.c
>> index be87320..8d478cf 100644
>> --- a/plugins/udevng.c
>> +++ b/plugins/udevng.c
>> @@ -800,11 +800,10 @@ static struct {
>> { "hso", "hso" },
>> { "gobi", "qcserial" },
>> { "sierra", "sierra" },
>> - { "huawei", "option", "201e", "2009" },
>> + { "huaweicdma", "option", "201e", "2009" },
>> { "huawei", "cdc_ether", "12d1" },
>> { "huawei", "option", "12d1" },
>> { "huaweicdma", "option", "12d1", "140b" },
>> - { "huaweicdma", "option", "201e" },
>> { "speedupcdma","option", "1c9e", "9e00" },
>> { "speedup", "option", "1c9e" },
>> { "speedup", "option", "2020" },
>
> the commit message does not explain why you are removing huaweicdma in
> general for VID 0x201e.
I've removed the generic configuration of HAIER's modem (0x201e) since
there is only one product ID used for the moment by this vendor (seen in
the option driver).
Do I need to only use the generic configuration and removing the
specific one to the PID 2009 or either simply add this comment in the
commit message?
>
> Regards
>
> Marcel
>
>
> _______________________________________________
> ofono mailing list
> ofono(a)ofono.org
> http://lists.ofono.org/listinfo/ofono
>
--
regards,
Nico
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] udevng: use huaweicdma driver for olive V-ME101
2012-01-05 16:05 ` nicolas.bertrand
@ 2012-01-05 19:17 ` Marcel Holtmann
2012-01-06 0:57 ` Deng, Ying An
1 sibling, 0 replies; 6+ messages in thread
From: Marcel Holtmann @ 2012-01-05 19:17 UTC (permalink / raw)
To: ofono
[-- Attachment #1: Type: text/plain, Size: 1444 bytes --]
Hi Nicolas,
> >> plugins/udevng.c | 3 +--
> >> 1 files changed, 1 insertions(+), 2 deletions(-)
> >>
> >> diff --git a/plugins/udevng.c b/plugins/udevng.c
> >> index be87320..8d478cf 100644
> >> --- a/plugins/udevng.c
> >> +++ b/plugins/udevng.c
> >> @@ -800,11 +800,10 @@ static struct {
> >> { "hso", "hso" },
> >> { "gobi", "qcserial" },
> >> { "sierra", "sierra" },
> >> - { "huawei", "option", "201e", "2009" },
> >> + { "huaweicdma", "option", "201e", "2009" },
> >> { "huawei", "cdc_ether", "12d1" },
> >> { "huawei", "option", "12d1" },
> >> { "huaweicdma", "option", "12d1", "140b" },
> >> - { "huaweicdma", "option", "201e" },
> >> { "speedupcdma","option", "1c9e", "9e00" },
> >> { "speedup", "option", "1c9e" },
> >> { "speedup", "option", "2020" },
> >
> > the commit message does not explain why you are removing huaweicdma in
> > general for VID 0x201e.
>
> I've removed the generic configuration of HAIER's modem (0x201e) since
> there is only one product ID used for the moment by this vendor (seen in
> the option driver).
>
> Do I need to only use the generic configuration and removing the
> specific one to the PID 2009 or either simply add this comment in the
> commit message?
you could just state this in the commit message. I think it is fine to
do this, but if you do not mention it, how should I know.
Regards
Marcel
^ permalink raw reply [flat|nested] 6+ messages in thread* RE: [PATCH] udevng: use huaweicdma driver for olive V-ME101
2012-01-05 16:05 ` nicolas.bertrand
2012-01-05 19:17 ` Marcel Holtmann
@ 2012-01-06 0:57 ` Deng, Ying An
1 sibling, 0 replies; 6+ messages in thread
From: Deng, Ying An @ 2012-01-06 0:57 UTC (permalink / raw)
To: ofono
[-- Attachment #1: Type: text/plain, Size: 2086 bytes --]
>-----Original Message-----
>From: ofono-bounces(a)ofono.org [mailto:ofono-bounces(a)ofono.org] On Behalf
>Of nicolas.bertrand
>Sent: Friday, January 06, 2012 12:05 AM
>To: ofono(a)ofono.org
>Subject: Re: [PATCH] udevng: use huaweicdma driver for olive V-ME101
>
>Hi Marcel,
>
>On 01/05/2012 09:03 AM, Marcel Holtmann wrote:
>> Hi Nicolas,
>>
>>> plugins/udevng.c | 3 +--
>>> 1 files changed, 1 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/plugins/udevng.c b/plugins/udevng.c
>>> index be87320..8d478cf 100644
>>> --- a/plugins/udevng.c
>>> +++ b/plugins/udevng.c
>>> @@ -800,11 +800,10 @@ static struct {
>>> { "hso", "hso" },
>>> { "gobi", "qcserial" },
>>> { "sierra", "sierra" },
>>> - { "huawei", "option", "201e", "2009" },
>>> + { "huaweicdma", "option", "201e", "2009" },
>>> { "huawei", "cdc_ether", "12d1" },
>>> { "huawei", "option", "12d1" },
>>> { "huaweicdma", "option", "12d1", "140b" },
>>> - { "huaweicdma", "option", "201e" },
>>> { "speedupcdma","option", "1c9e", "9e00" },
>>> { "speedup", "option", "1c9e" },
>>> { "speedup", "option", "2020" },
>>
>> the commit message does not explain why you are removing huaweicdma in
>> general for VID 0x201e.
>
>I've removed the generic configuration of HAIER's modem (0x201e) since
>there is only one product ID used for the moment by this vendor (seen in
>the option driver).
>
>Do I need to only use the generic configuration and removing the
>specific one to the PID 2009 or either simply add this comment in the
>commit message?
Haier helps many carriers to OEM dongles, including GSM/CDMA/TDS-CDMA/LTE..
So it'd not be a good idea to force all Haier dongle to load cdma driver.
>>
>> Regards
>>
>> Marcel
>>
>>
>> _______________________________________________
>> ofono mailing list
>> ofono(a)ofono.org
>> http://lists.ofono.org/listinfo/ofono
>>
>
>--
>regards,
>Nico
>_______________________________________________
>ofono mailing list
>ofono(a)ofono.org
>http://lists.ofono.org/listinfo/ofono
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2012-01-06 0:57 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-11-18 12:27 [PATCH] udevng: use huaweicdma driver for olive V-ME101 Nicolas Bertrand
2012-01-05 2:28 ` Deng, Ying An
2012-01-05 8:03 ` Marcel Holtmann
2012-01-05 16:05 ` nicolas.bertrand
2012-01-05 19:17 ` Marcel Holtmann
2012-01-06 0:57 ` Deng, Ying An
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.