From: Larry Finger <Larry.Finger@lwfinger.net>
To: Fabio Estevam <festevam@gmail.com>
Cc: netdev@vger.kernel.org, linux-wireless@vger.kernel.org,
gwingerde@gmail.com, linville@tuxdriver.com, davem@davemloft.net,
Fabio Estevam <fabio.estevam@freescale.com>
Subject: Re: [PATCH v2] drivers: net: Fix dependency for EEPROM_93CX6
Date: Thu, 05 Jan 2012 10:11:21 -0600 [thread overview]
Message-ID: <4F05CBA9.1070602@lwfinger.net> (raw)
In-Reply-To: <1325770673-17309-1-git-send-email-festevam@gmail.com>
On 01/05/2012 07:37 AM, Fabio Estevam wrote:
> Fix the following build warning:
>
> warning: (KS8851&& AX88796_93CX6&& RTL8180&& RTL8187&& ADM8211&& RT2400PCI&& RT2500PCI&& RT61PCI&& RT2800PCI&& R8187SE) selects EEPROM_93CX6 which has unmet direct dependencies (MISC_DEVICES)
>
> Signed-off-by: Fabio Estevam<fabio.estevam@freescale.com>
> ---
> Changes since v1:
> - Place MISC_DEVICES dependency into the 'depends on' line
Is this the right way to fix this? Whenever I get this kind of build warning, I
usually attribute it to a problem with my local configuration and fix my copy of
.config, not modify the build system. With this change, it seems to me that a
lot of devices will suddenly disappear from the build with little explanation. I
don't feel confident enough to NACK the patch, but I would like an expert to
comment.
I have noticed that the defconfigs for various architectures are split between
turning MISC_DEVICES on or off.
Larry
WARNING: multiple messages have this Message-ID (diff)
From: Larry Finger <Larry.Finger-tQ5ms3gMjBLk1uMJSBkQmQ@public.gmane.org>
To: Fabio Estevam <festevam-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
gwingerde-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
linville-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org,
davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org,
Fabio Estevam
<fabio.estevam-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
Subject: Re: [PATCH v2] drivers: net: Fix dependency for EEPROM_93CX6
Date: Thu, 05 Jan 2012 10:11:21 -0600 [thread overview]
Message-ID: <4F05CBA9.1070602@lwfinger.net> (raw)
In-Reply-To: <1325770673-17309-1-git-send-email-festevam-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
On 01/05/2012 07:37 AM, Fabio Estevam wrote:
> Fix the following build warning:
>
> warning: (KS8851&& AX88796_93CX6&& RTL8180&& RTL8187&& ADM8211&& RT2400PCI&& RT2500PCI&& RT61PCI&& RT2800PCI&& R8187SE) selects EEPROM_93CX6 which has unmet direct dependencies (MISC_DEVICES)
>
> Signed-off-by: Fabio Estevam<fabio.estevam-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
> ---
> Changes since v1:
> - Place MISC_DEVICES dependency into the 'depends on' line
Is this the right way to fix this? Whenever I get this kind of build warning, I
usually attribute it to a problem with my local configuration and fix my copy of
.config, not modify the build system. With this change, it seems to me that a
lot of devices will suddenly disappear from the build with little explanation. I
don't feel confident enough to NACK the patch, but I would like an expert to
comment.
I have noticed that the defconfigs for various architectures are split between
turning MISC_DEVICES on or off.
Larry
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2012-01-05 16:11 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-05 13:37 [PATCH v2] drivers: net: Fix dependency for EEPROM_93CX6 Fabio Estevam
2012-01-05 13:37 ` Fabio Estevam
2012-01-05 16:11 ` Larry Finger [this message]
2012-01-05 16:11 ` Larry Finger
2012-01-05 17:03 ` Ben Hutchings
2012-01-05 17:03 ` Ben Hutchings
2012-01-05 17:20 ` David Miller
2012-01-05 17:20 ` David Miller
2012-01-05 18:06 ` Fabio Estevam
2012-01-05 18:06 ` Fabio Estevam
2012-01-05 19:02 ` Fabio Estevam
2012-01-05 19:17 ` Ben Hutchings
2012-01-05 19:21 ` David Miller
2012-01-05 19:21 ` David Miller
2012-01-05 20:16 ` Larry Finger
2012-01-05 20:16 ` Larry Finger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F05CBA9.1070602@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=davem@davemloft.net \
--cc=fabio.estevam@freescale.com \
--cc=festevam@gmail.com \
--cc=gwingerde@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.