All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Weinberger <richard@nod.at>
To: Bart De Schuymer <bdschuym@pandora.be>
Cc: netdev@vger.kernel.org, bridge@lists.linux-foundation.org,
	linux-kernel@vger.kernel.org, netfilter-devel@vger.kernel.org,
	Stephen Hemminger <shemminger@vyatta.com>,
	davem@davemloft.net
Subject: Re: [Bridge] [PATCH] netfilter: Fix br_nf_pre_routing() in conjunction with bridge-nf-call-ip(6)tables=0
Date: Thu, 05 Jan 2012 20:54:55 +0100	[thread overview]
Message-ID: <4F06000F.10303@nod.at> (raw)
In-Reply-To: <4F05FF15.5010809@pandora.be>

[-- Attachment #1: Type: text/plain, Size: 772 bytes --]

Am 05.01.2012 20:50, schrieb Bart De Schuymer:
> Op 5/01/2012 0:13, Richard Weinberger schreef:
>>
>> Let's export brnf_call_iptables and brnf_call_ip6tables, such that
>> physdev_mt_check() can notify the user that his iptables rule will have
>> no effect.
>>
> 
> I don't want to introduce a runtime dependency between the iptables
> physdev module and the bridge module.
> This should keep working:
> #modprobe bridge
> #modprobe xt_physdev
> #rmmod bridge
> It will stop working if you use exported symbols of the bridge module in
> the physdev module.
> 

IMHO this behavior would be useful. 8-)

Removing bridge while xt_physdev is loaded will make some netfilter
rules void.
Which is not fun on a production firewall.

Thanks,
//richard


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 490 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Richard Weinberger <richard@nod.at>
To: Bart De Schuymer <bdschuym@pandora.be>
Cc: Stephen Hemminger <shemminger@vyatta.com>,
	davem@davemloft.net, bridge@lists.linux-foundation.org,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	netfilter-devel@vger.kernel.org
Subject: Re: [PATCH] netfilter: Fix br_nf_pre_routing() in conjunction with bridge-nf-call-ip(6)tables=0
Date: Thu, 05 Jan 2012 20:54:55 +0100	[thread overview]
Message-ID: <4F06000F.10303@nod.at> (raw)
In-Reply-To: <4F05FF15.5010809@pandora.be>

[-- Attachment #1: Type: text/plain, Size: 772 bytes --]

Am 05.01.2012 20:50, schrieb Bart De Schuymer:
> Op 5/01/2012 0:13, Richard Weinberger schreef:
>>
>> Let's export brnf_call_iptables and brnf_call_ip6tables, such that
>> physdev_mt_check() can notify the user that his iptables rule will have
>> no effect.
>>
> 
> I don't want to introduce a runtime dependency between the iptables
> physdev module and the bridge module.
> This should keep working:
> #modprobe bridge
> #modprobe xt_physdev
> #rmmod bridge
> It will stop working if you use exported symbols of the bridge module in
> the physdev module.
> 

IMHO this behavior would be useful. 8-)

Removing bridge while xt_physdev is loaded will make some netfilter
rules void.
Which is not fun on a production firewall.

Thanks,
//richard


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 490 bytes --]

  reply	other threads:[~2012-01-05 19:54 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-03  1:29 xt_physdev has no effect if net.bridge.bridge-nf-call-iptables=0 Richard Weinberger
2012-01-03 13:26 ` [Bridge] " Richard Weinberger
2012-01-03 13:26   ` Richard Weinberger
2012-01-03 13:26   ` [Bridge] [PATCH] netfilter: Fix br_nf_pre_routing() in conjunction with bridge-nf-call-ip(6)tables=0 Richard Weinberger
2012-01-03 13:26     ` Richard Weinberger
2012-01-03 16:15     ` [Bridge] " Stephen Hemminger
2012-01-03 16:15       ` Stephen Hemminger
2012-01-03 17:42       ` [Bridge] " Richard Weinberger
2012-01-03 17:42         ` Richard Weinberger
2012-01-03 20:15         ` [Bridge] " Bart De Schuymer
2012-01-03 20:15           ` Bart De Schuymer
2012-01-03 20:29           ` [Bridge] " Richard Weinberger
2012-01-03 20:29             ` Richard Weinberger
2012-01-04 17:55             ` [Bridge] " Bart De Schuymer
2012-01-04 17:55               ` Bart De Schuymer
2012-01-04 23:13               ` [Bridge] " Richard Weinberger
2012-01-04 23:13                 ` Richard Weinberger
2012-01-05 19:50                 ` [Bridge] " Bart De Schuymer
2012-01-05 19:50                   ` Bart De Schuymer
2012-01-05 19:50                   ` Bart De Schuymer
2012-01-05 19:54                   ` Richard Weinberger [this message]
2012-01-05 19:54                     ` Richard Weinberger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F06000F.10303@nod.at \
    --to=richard@nod.at \
    --cc=bdschuym@pandora.be \
    --cc=bridge@lists.linux-foundation.org \
    --cc=davem@davemloft.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=shemminger@vyatta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.