From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Joe Perches <joe@perches.com>
Cc: linville@tuxdriver.com, sfr@canb.auug.org.au,
netdev@vger.kernel.org, linux-wireless@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-next@vger.kernel.org,
ath6kl-devel@qualcomm.com, davem@davemloft.net
Subject: Re: [PATCH v2 5/6] ath6kl: convert ath6kl_dbg() and ath6kl_dbg_dump() into functions
Date: Fri, 6 Jan 2012 10:14:17 +0200 [thread overview]
Message-ID: <4F06AD59.3050207@qca.qualcomm.com> (raw)
In-Reply-To: <1325781489.22154.19.camel@joe2Laptop>
Hi Joe,
On 01/05/2012 06:38 PM, Joe Perches wrote:
> On Thu, 2012-01-05 at 15:28 +0200, Kalle Valo wrote:
>
>> diff --git a/drivers/net/wireless/ath/ath6kl/debug.c b/drivers/net/wireless/ath/ath6kl/debug.c
> []
>> +void ath6kl_dbg(enum ATH6K_DEBUG_MASK mask, const char *fmt, ...)
> []
>> + ath6kl_printk(KERN_DEBUG, "%pV", &vaf);
> [
>> diff --git a/drivers/net/wireless/ath/ath6kl/debug.h b/drivers/net/wireless/ath/ath6kl/debug.h
> []
>> +void ath6kl_dbg(enum ATH6K_DEBUG_MASK mask, const char *fmt, ...);
>
> You need to add
>
> __printf(2, 3)
>
> to the prototype.
>
> If it's not there, the printf formats and arguments aren't verified.
> %pV could do the wrong/bad things.
Nice, I'll add that to v3. Thanks again.
Kalle
WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Joe Perches <joe@perches.com>
Cc: <linville@tuxdriver.com>, <sfr@canb.auug.org.au>,
<netdev@vger.kernel.org>, <linux-wireless@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <linux-next@vger.kernel.org>,
<ath6kl-devel@qualcomm.com>, <davem@davemloft.net>
Subject: Re: [PATCH v2 5/6] ath6kl: convert ath6kl_dbg() and ath6kl_dbg_dump() into functions
Date: Fri, 6 Jan 2012 10:14:17 +0200 [thread overview]
Message-ID: <4F06AD59.3050207@qca.qualcomm.com> (raw)
In-Reply-To: <1325781489.22154.19.camel@joe2Laptop>
Hi Joe,
On 01/05/2012 06:38 PM, Joe Perches wrote:
> On Thu, 2012-01-05 at 15:28 +0200, Kalle Valo wrote:
>
>> diff --git a/drivers/net/wireless/ath/ath6kl/debug.c b/drivers/net/wireless/ath/ath6kl/debug.c
> []
>> +void ath6kl_dbg(enum ATH6K_DEBUG_MASK mask, const char *fmt, ...)
> []
>> + ath6kl_printk(KERN_DEBUG, "%pV", &vaf);
> [
>> diff --git a/drivers/net/wireless/ath/ath6kl/debug.h b/drivers/net/wireless/ath/ath6kl/debug.h
> []
>> +void ath6kl_dbg(enum ATH6K_DEBUG_MASK mask, const char *fmt, ...);
>
> You need to add
>
> __printf(2, 3)
>
> to the prototype.
>
> If it's not there, the printf formats and arguments aren't verified.
> %pV could do the wrong/bad things.
Nice, I'll add that to v3. Thanks again.
Kalle
next prev parent reply other threads:[~2012-01-06 8:14 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-05 13:25 [PATCH v2 0/6] ath6kl: create ath6kl_core.ko Kalle Valo
2012-01-05 13:26 ` [PATCH v2 1/6] ath6kl: rename vif init and cleanup functions Kalle Valo
2012-01-05 13:26 ` [PATCH v2 2/6] ath6kl: unify cfg80211 init/cleanup functions Kalle Valo
2012-01-05 13:27 ` [PATCH v2 3/6] ath6kl: create core.c Kalle Valo
2012-01-05 13:28 ` [PATCH v2 4/6] ath6kl: get rid of AR_DBG_LVL_CHECK() Kalle Valo
2012-01-05 14:14 ` David Laight
2012-01-05 14:14 ` David Laight
2012-01-06 8:08 ` Kalle Valo
2012-01-06 8:08 ` Kalle Valo
2012-01-05 13:28 ` [PATCH v2 5/6] ath6kl: convert ath6kl_dbg() and ath6kl_dbg_dump() into functions Kalle Valo
2012-01-05 16:38 ` Joe Perches
2012-01-06 8:14 ` Kalle Valo [this message]
2012-01-06 8:14 ` Kalle Valo
2012-01-05 13:28 ` [PATCH v2 6/6] ath6kl: create ath6kl_core.ko Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F06AD59.3050207@qca.qualcomm.com \
--to=kvalo@qca.qualcomm.com \
--cc=ath6kl-devel@qualcomm.com \
--cc=davem@davemloft.net \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.