Re: [Qemu-devel] [PATCH 06/12] xhci: Initial xHCI implementation

[Stefan Weil <sw@weilnetz.de>]

Am 06.01.2012 14:59, schrieb Gerd Hoffmann:
> From: Hector Martin <hector@marcansoft.com>
>
> Based on the implementation from Hector Martin <hector@marcansoft.com>
>
> Hectors's implementation completely sidestepped the qemu usb system and
> used libusb directly for usb device pass through. So I've ripped out
> the libusb bits (or left them in disabled, as reference for further
> coding) and hooked up the qemu subsystem instead. That work is not
> complete yet though, partly due to limitations of the qemu usb
> subsystem. Nevertheless I think it is better to continue development
> in-tree, especially as the qemu usb bits need a bunch of improvements
> too for decent usb 3.0 support.
>
> Current state:
> - usb-storage emulation should work ok.
> - Devices which need constant polling (HID emulation like usb-tablet)
> are known to not work.
> - ISO xfers are not implemented yet.
> - superspeed ports are not implemented yet.
> - usb pass-through is completely untested so far.
>
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
> Makefile.objs | 1 +
> default-configs/pci.mak | 1 +
> hw/pci_ids.h | 3 +
> hw/usb-xhci.c | 2662 +++++++++++++++++++++++++++++++++++++++++++++++
> 4 files changed, 2667 insertions(+), 0 deletions(-)
> create mode 100644 hw/usb-xhci.c

Hi,

please use scripts/checkpatch.pl to test this patch.

It contains several indented statements (if ... else)
without braces.

For code which is also used in a non QEMU context,
tools like AStyle can fix the formatting for QEMU.

Cheers,
Stefan Weil