* [PATCH] em28xx: Fix: I2C_CLK write error message checks wrong return code
@ 2012-01-08 20:19 Sascha Sommer
0 siblings, 0 replies; only message in thread
From: Sascha Sommer @ 2012-01-08 20:19 UTC (permalink / raw)
To: Linux Media Mailing List
[-- Attachment #1: Type: text/plain, Size: 170 bytes --]
Hello,
it looks like the return value check that is done after setting the I2C
speed checks the wrong return code.
Attached patch fixes this problem.
Regards
Sascha
[-- Attachment #2: em28xx_check_correct_return_code_after_register_write.patch --]
[-- Type: text/x-patch, Size: 744 bytes --]
Fix: I2C_CLK write error message checks wrong return code
Signed-off-by: Sascha Sommer <saschasommer@freenet.de>
diff --git a/drivers/media/video/em28xx/em28xx-cards.c b/drivers/media/video/em28xx/em28xx-cards.c
index 897a432..349e674 100644
--- a/drivers/media/video/em28xx/em28xx-cards.c
+++ b/drivers/media/video/em28xx/em28xx-cards.c
@@ -3015,7 +3015,7 @@ static int em28xx_init_dev(struct em28xx **devhandle, struct usb_device *udev,
if (!dev->board.is_em2800) {
/* Resets I2C speed */
- em28xx_write_reg(dev, EM28XX_R06_I2C_CLK, dev->board.i2c_speed);
+ retval = em28xx_write_reg(dev, EM28XX_R06_I2C_CLK, dev->board.i2c_speed);
if (retval < 0) {
em28xx_errdev("%s: em28xx_write_reg failed!"
" retval [%d]\n",
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2012-01-07 20:23 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-01-08 20:19 [PATCH] em28xx: Fix: I2C_CLK write error message checks wrong return code Sascha Sommer
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.