Re: [PATCH 4/4] babeltrace: Integrated from version 0.8

[Zumeng Chen <zumeng.chen@windriver.com>]

于 2012年01月07日 23:54, Darren Hart 写道:
>
> On 01/05/2012 10:11 PM, Zumeng Chen wrote:
>    
>> It provides trace read and write libraries, as well as a trace converter.
>>
>> Signed-off-by: Zumeng Chen<zumeng.chen@windriver.com>
>> ---
>>   meta/recipes-kernel/lttng-2.0/babeltrace_0.8.bb |   30 +++++++++++++++++++++++
>>   1 files changed, 30 insertions(+), 0 deletions(-)
>>   create mode 100644 meta/recipes-kernel/lttng-2.0/babeltrace_0.8.bb
>>
>> diff --git a/meta/recipes-kernel/lttng-2.0/babeltrace_0.8.bb b/meta/recipes-kernel/lttng-2.0/babeltrace_0.8.bb
>> new file mode 100644
>> index 0000000..86a9d01
>> --- /dev/null
>> +++ b/meta/recipes-kernel/lttng-2.0/babeltrace_0.8.bb
>> @@ -0,0 +1,30 @@
>> +SUMMARY = "Babeltrace - Trace Format Babel Tower"
>> +DESCRIPTION = "Babeltrace provides trace read and write libraries in host side,\
>> +	       as well as a trace converter, which used to convert LTTng 2.0 \
>> +	       traces into human-readable log."
>>      
> In the previous patches you aligned the additional lines with column 0,
> here you indent with tabs and spaces. A quick survey of the existing
> sources suggest the DESCRIPTION field typically does not indent the
> subsequent lines.
>    
OK. fixed.
>    
>> +HOMEPAGE = "http://www.efficios.com/babeltrace/"
>> +BUGTRACKER = "n/a"
>> +
>> +LICENSE = "MIT&  GPLV2"
>> +LIC_FILES_CHKSUM = "file://LICENSE;md5=8d1a03b3c17bdd158b3cbb34813b1423"
>> +
>> +inherit autotools
>> +
>> +DEPENDS = "gtk+ util-linux"
>> +
>> +SRCREV = "31e670293588d7882a232bc14b93d5e956fa43f4"
>> +PV = "0.8+git${SRCPV}"
>> +PR = "r0"
>> +
>> +SRC_URI += "git://git.efficios.com/babeltrace.git;protocol=git"
>> +
>>      
> This should be a "=" assignment, not "+=".
>    
fixed.
>    
>> +S = "${WORKDIR}/git"
>> +
>> +do_configure_prepend () {
>> +  ${S}/bootstrap
>>      
> Please use tabs for indentation here.
>    
fixed.
>    
>> +}
>> +
>> +# Due to liburcu not building on MIPS currently this recipe needs to
>> +# be limited also.
>> +# So here let us first suppport x86/arm/powerpc platforms now.
>> +COMPATIBLE_HOST = '(x86_64.*|i.86.*|arm.*|powerpc.*)-linux'
>>      
> Again, I think you want to filter based on target arch.
>