Re: [PATCH 2/4] lttng-tools: Integrated from git repo.

[Zumeng Chen <zumeng.chen@windriver.com>]

于 2012年01月07日 10:05, Darren Hart 写道:
> This commit message doesn't tell me anything about what this patch is
> intended to do.
>
>    
>> +++ b/meta/recipes-kernel/lttng-2.0/lttng-tools-fix-compiling-error-for-powerpc-arm-and-mips.patch
>> @@ -0,0 +1,23 @@
>> +Upstream-Status: Pending
>> +
>> +lttng-tools: fix compiling error for powerpc, arm
>> +
>>      
> Add some commentary here about what the compilation error is.
>    
OK. in V2.
>    
>> +Signed-off-by: Zumeng Chen<zumeng.chen@windriver.com>
>> +---
>> + librunas/runas.c |    1 +
>> + 1 files changed, 1 insertions(+), 0 deletions(-)
>> +
>> +diff --git a/librunas/runas.c b/librunas/runas.c
>> +--- a/librunas/runas.c
>> ++++ b/librunas/runas.c
>> +@@ -29,6 +29,7 @@
>> + #include<fcntl.h>
>> + #include<sched.h>
>> + #include<sys/mman.h>
>> ++#include<asm/mman.h>
>> +
>> + #include<lttngerr.h>
>> +
>> +--
>> +1.7.5.4
>> +
>> diff --git a/meta/recipes-kernel/lttng-2.0/lttng-tools_2.0-pre16.bb b/meta/recipes-kernel/lttng-2.0/lttng-tools_2.0-pre16.bb
>> new file mode 100644
>> index 0000000..0b7a240
>> --- /dev/null
>> +++ b/meta/recipes-kernel/lttng-2.0/lttng-tools_2.0-pre16.bb
>> @@ -0,0 +1,24 @@
>> +SECTION = "devel"
>> +SUMMARY = "Linux Trace Toolkit Control"
>> +DESCRIPTION = "The Linux trace toolkit is a suite of tools designed to \
>> +extract program execution details from the Linux operating system and  \
>> +interpret them."
>> +LICENSE = "GPLv2.1"
>> +LIC_FILES_CHKSUM = "file://COPYING;md5=ab682a4729389c3f11913d758affe98e"
>> +
>> +DEPENDS = "liburcu popt lttng-ust"
>> +
>> +SRC_URI = "http://lttng.org/files/lttng-tools/lttng-tools-${PV}.tar.bz2 \
>> +	   file://fix-compiling-error-for-powerpc-arm-and-mips.patch"
>>      
> Whitespace error. Indent with spaces after the initial block indent
> (which doesn't exist here).
>    
fix.ed
>    
>> +
>> +SRC_URI[md5sum] = "58ed0a15db80a00172d5b0413a55451c"
>> +SRC_URI[sha256sum] = "188d262bda80043dd939c9aa7aec1795ca77aeec0cb3c0f23c28bfe754049491"
>> +
>> +S = "${WORKDIR}/lttng-tools-${PV}"
>> +
>> +
>> +inherit autotools
>> +
>> +export KERNELDIR="${STAGING_KERNEL_DIR}"
>> +
>> +COMPATIBLE_HOST = '(x86_64.*|i.86.*|arm.*|powerpc.*)-linux'
>>      
> This requires a comment as in the previous patch. Again, I don't think
> this is what you are looking for. You want to limit which target
> architectures you build this for. Right?
>    
Right, but the same reason for another email.

Regards,
Zumeng