Re: [PATCH 2/4] lttng-tools: Integrated from git repo.

[Darren Hart <dvhart@linux.intel.com>]

On 01/09/2012 01:24 AM, Zumeng Chen wrote:
> This patch intended to integrate the Linux trace toolkit, which
> is a suite of tools designed to extract program execution details
> from the Linux operating system and interpret them.
> 
> lttng-tools 2.0 is currently in pre-release(-pre16), so we have to
> update it when official released.
> 
> Signed-off-by: Zumeng Chen <zumeng.chen@windriver.com>
> ---
>  ...tools-fix-compiling-error-for-powerpc-arm.patch |   26 ++++++++++++++++++++
>  .../lttng-2.0/lttng-tools_2.0-pre16.bb             |   21 ++++++++++++++++
>  2 files changed, 47 insertions(+), 0 deletions(-)
>  create mode 100644 meta/recipes-kernel/lttng-2.0/lttng-tools-fix-compiling-error-for-powerpc-arm.patch
>  create mode 100644 meta/recipes-kernel/lttng-2.0/lttng-tools_2.0-pre16.bb
> 
> diff --git a/meta/recipes-kernel/lttng-2.0/lttng-tools-fix-compiling-error-for-powerpc-arm.patch b/meta/recipes-kernel/lttng-2.0/lttng-tools-fix-compiling-error-for-powerpc-arm.patch
> new file mode 100644
> index 0000000..47b7b98
> --- /dev/null
> +++ b/meta/recipes-kernel/lttng-2.0/lttng-tools-fix-compiling-error-for-powerpc-arm.patch
> @@ -0,0 +1,26 @@
> +Upstream-Status: Pending
> +
> +lttng-tools: fix compiling error for powerpc, arm
> +
> +For powerpc and arm system, some MAP_ defined in
> +asm/mman.h, so we include it in header.
> +
> +Signed-off-by: Zumeng Chen <zumeng.chen@windriver.com>
> +---
> + librunas/runas.c |    1 +
> + 1 files changed, 1 insertions(+), 0 deletions(-)
> +
> +diff --git a/librunas/runas.c b/librunas/runas.c
> +--- a/librunas/runas.c
> ++++ b/librunas/runas.c
> +@@ -29,6 +29,7 @@
> + #include <fcntl.h>
> + #include <sched.h>
> + #include <sys/mman.h>
> ++#include <asm/mman.h>
> +
> + #include <lttngerr.h>
> +
> +--
> +1.7.5.4
> +
> diff --git a/meta/recipes-kernel/lttng-2.0/lttng-tools_2.0-pre16.bb b/meta/recipes-kernel/lttng-2.0/lttng-tools_2.0-pre16.bb
> new file mode 100644
> index 0000000..8a688c9
> --- /dev/null
> +++ b/meta/recipes-kernel/lttng-2.0/lttng-tools_2.0-pre16.bb
> @@ -0,0 +1,21 @@
> +SECTION = "devel"
> +SUMMARY = "Linux Trace Toolkit Control"
> +DESCRIPTION = "The Linux trace toolkit is a suite of tools designed to extract program execution details from the Linux operating system and interpret them."

Please do wrap long lines, just don't indent them with tabs past the
previous line:

DESCRIPTION = "The Linux trace toolkit is a suite of tools designed \
to extract program execution details from the Linux operating system \
and interpret them."

> +LICENSE = "GPLv2.1"
> +LIC_FILES_CHKSUM = "file://COPYING;md5=ab682a4729389c3f11913d758affe98e"
> +
> +DEPENDS = "liburcu popt lttng-ust"
> +
> +SRC_URI = "http://lttng.org/files/lttng-tools/lttng-tools-${PV}.tar.bz2 \
> +           file://lttng-tools-fix-compiling-error-for-powerpc-arm.patch"
> +
> +SRC_URI[md5sum] = "58ed0a15db80a00172d5b0413a55451c"
> +SRC_URI[sha256sum] = "188d262bda80043dd939c9aa7aec1795ca77aeec0cb3c0f23c28bfe754049491"
> +
> +S = "${WORKDIR}/lttng-tools-${PV}"
> +
> +inherit autotools
> +
> +export KERNELDIR="${STAGING_KERNEL_DIR}"
> +

Please include the reason for the COMPATIBLE_HOST test in all recipes.

> +COMPATIBLE_HOST = '(x86_64.*|i.86.*|arm.*|powerpc.*)-linux'

-- 
Darren Hart
Intel Open Source Technology Center
Yocto Project - Linux Kernel