media_build failures on 3.0.6 Gentoo

media_build failures on 3.0.6 Gentoo

[Fredrik Lingvall]

Hi,

I get this build failure:

lin-tv src # git clone git://linuxtv.org/media_build.git
lin-tv src # cd media_build/
lin-tv media_build # ./build
Checking if the needed tools are present
Needed package dependencies are met.

************************************************************
* This script will download the latest tarball and build it*
* Assuming that your kernel is compatible with the latest  *
* drivers. If not, you'll need to add some extra backports,*
* ./backports/<kernel> directory.                          *
* It will also update this tree to be sure that all compat *
* bits are there, to avoid compilation failures            *
************************************************************
************************************************************
* All drivers and build system are under GPLv2 License     *
* Firmware files are under the license terms found at:     *
* http://www.linuxtv.org/downloads/firmware/               *
* Please abort if you don't agree with the license         *
************************************************************

****************************
Updating the building system
****************************
 From git://linuxtv.org/media_build
  * branch            master     -> FETCH_HEAD
Already up-to-date.
make: Entering directory `/usr/src/media_build/linux'
wget http://linuxtv.org/downloads/drivers/linux-media-LATEST.tar.bz2.md5 
-O linux-media.tar.bz2.md5.tmp
--2011-12-21 11:42:05--  
http://linuxtv.org/downloads/drivers/linux-media-LATEST.tar.bz2.md5
Resolving linuxtv.org... 130.149.80.248
Connecting to linuxtv.org|130.149.80.248|:80... connected.
HTTP request sent, awaiting response... 200 OK
Length: 93 [application/x-bzip2]
Saving to: `linux-media.tar.bz2.md5.tmp'

100%[=============================================================================>] 
93          --.-K/s   in 0s

2011-12-21 11:42:05 (11.1 MB/s) - `linux-media.tar.bz2.md5.tmp' saved 
[93/93]


<snip>

  LD [M]  /usr/src/media_build/v4l/m5mols.o
   CC [M]  /usr/src/media_build/v4l/s5k6aa.o
   CC [M]  /usr/src/media_build/v4l/adp1653.o
   CC [M]  /usr/src/media_build/v4l/as3645a.o
/usr/src/media_build/v4l/as3645a.c: In function 'as3645a_probe':
/usr/src/media_build/v4l/as3645a.c:815:2: error: implicit declaration of 
function 'kzalloc'
/usr/src/media_build/v4l/as3645a.c:815:8: warning: assignment makes 
pointer from integer without a cast
make[3]: *** [/usr/src/media_build/v4l/as3645a.o] Error 1
make[2]: *** [_module_/usr/src/media_build/v4l] Error 2
make[2]: Leaving directory `/usr/src/linux-3.0.6-gentoo'
make[1]: *** [default] Error 2
make[1]: Leaving directory `/usr/src/media_build/v4l'
make: *** [all] Error 2
build failed at ./build line 380.
lin-tv media_build #

Regards,

/Fredrik

Re: media_build failures on 3.0.6 Gentoo

[Laurent Pinchart]

Hi Fredrik,

On Wednesday 21 December 2011 11:50:53 Fredrik Lingvall wrote:
> Hi,
> 
> I get this build failure:

[snip]

>   LD [M]  /usr/src/media_build/v4l/m5mols.o
>    CC [M]  /usr/src/media_build/v4l/s5k6aa.o
>    CC [M]  /usr/src/media_build/v4l/adp1653.o
>    CC [M]  /usr/src/media_build/v4l/as3645a.o
> /usr/src/media_build/v4l/as3645a.c: In function 'as3645a_probe':
> /usr/src/media_build/v4l/as3645a.c:815:2: error: implicit declaration of
> function 'kzalloc'
> /usr/src/media_build/v4l/as3645a.c:815:8: warning: assignment makes
> pointer from integer without a cast
> make[3]: *** [/usr/src/media_build/v4l/as3645a.o] Error 1
> make[2]: *** [_module_/usr/src/media_build/v4l] Error 2
> make[2]: Leaving directory `/usr/src/linux-3.0.6-gentoo'
> make[1]: *** [default] Error 2
> make[1]: Leaving directory `/usr/src/media_build/v4l'
> make: *** [all] Error 2
> build failed at ./build line 380.
> lin-tv media_build #

Could you please test this patch ?

>From c7ecae9b57cb29eaa134943d086fb0d83865514e Mon Sep 17 00:00:00 2001
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Date: Mon, 9 Jan 2012 00:18:19 +0100
Subject: [PATCH] as3645a: Fix compilation by including slab.h

The as3645a driver calls kzalloc(). Include slab.h.

Reported-by: Fredrik Lingvall <fredrik.lingvall@gmail.com>
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
 drivers/media/video/as3645a.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/media/video/as3645a.c b/drivers/media/video/as3645a.c
index ec859a5..f241702 100644
--- a/drivers/media/video/as3645a.c
+++ b/drivers/media/video/as3645a.c
@@ -29,6 +29,7 @@
 #include <linux/i2c.h>
 #include <linux/module.h>
 #include <linux/mutex.h>
+#include <linux/slab.h>
 
 #include <media/as3645a.h>
 #include <media/v4l2-ctrls.h>
-- 
Regards,

Laurent Pinchart

Re: media_build failures on 3.0.6 Gentoo

[Fredrik Lingvall]

On 01/09/12 00:22, Laurent Pinchart wrote:
> Hi Fredrik,
>
> On Wednesday 21 December 2011 11:50:53 Fredrik Lingvall wrote:
>> Hi,
>>
>> I get this build failure:
> [snip]
>
>>    LD [M]  /usr/src/media_build/v4l/m5mols.o
>>     CC [M]  /usr/src/media_build/v4l/s5k6aa.o
>>     CC [M]  /usr/src/media_build/v4l/adp1653.o
>>     CC [M]  /usr/src/media_build/v4l/as3645a.o
>> /usr/src/media_build/v4l/as3645a.c: In function 'as3645a_probe':
>> /usr/src/media_build/v4l/as3645a.c:815:2: error: implicit declaration of
>> function 'kzalloc'
>> /usr/src/media_build/v4l/as3645a.c:815:8: warning: assignment makes
>> pointer from integer without a cast
>> make[3]: *** [/usr/src/media_build/v4l/as3645a.o] Error 1
>> make[2]: *** [_module_/usr/src/media_build/v4l] Error 2
>> make[2]: Leaving directory `/usr/src/linux-3.0.6-gentoo'
>> make[1]: *** [default] Error 2
>> make[1]: Leaving directory `/usr/src/media_build/v4l'
>> make: *** [all] Error 2
>> build failed at ./build line 380.
>> lin-tv media_build #
> Could you please test this patch ?
>
>  From c7ecae9b57cb29eaa134943d086fb0d83865514e Mon Sep 17 00:00:00 2001
> From: Laurent Pinchart<laurent.pinchart@ideasonboard.com>
> Date: Mon, 9 Jan 2012 00:18:19 +0100
> Subject: [PATCH] as3645a: Fix compilation by including slab.h
>
> The as3645a driver calls kzalloc(). Include slab.h.
>
> Reported-by: Fredrik Lingvall<fredrik.lingvall@gmail.com>
> Signed-off-by: Laurent Pinchart<laurent.pinchart@ideasonboard.com>
> ---
>   drivers/media/video/as3645a.c |    1 +
>   1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/media/video/as3645a.c b/drivers/media/video/as3645a.c
> index ec859a5..f241702 100644
> --- a/drivers/media/video/as3645a.c
> +++ b/drivers/media/video/as3645a.c
> @@ -29,6 +29,7 @@
>   #include<linux/i2c.h>
>   #include<linux/module.h>
>   #include<linux/mutex.h>
> +#include<linux/slab.h>
>
>   #include<media/as3645a.h>
>   #include<media/v4l2-ctrls.h>
Laurent,

I have upgraded to the latest stable Gentoo kernel, that is 
3.1.6-gentoo, and I don't see the build problem with

http://linuxtv.org/downloads/drivers/linux-media-2012-01-07.tar.bz2

and above anymore (I had to enable DVB for Linux in the 3.1.6-gentoo 
kernel) .

As of linux-media-2012-01-07.tar.bz2 I can now see clear video with 
mplayer on some channels (using the HVR-930C)  but it's not working 
perfectly, in particular not with MythTV. I will do some more testing 
and report back in the "Hauppauge HVR-930C problems" thread.

Regards,

/Fredrik