Re: [Qemu-devel] Please read: make check framework

[Stefan Weil <sw@weilnetz.de>]

Am 09.01.2012 17:04, schrieb Anthony Liguori:
> Hi,
>
> I'm going to apply this series quickly and will start running 'make 
> check-quick' as part a sniff test before pushing patches.
>
> I'd like to request that all maintainers/submaintainers do the same 
> and that everyone contributes unit tests to this target.
>
> The general rules for 'make check-quick':
>
>  1) It must complete in less than 10 minutes start to finish (the 
> entire rule).  We can re-examine this over time but for now, it seems 
> like a reasonable limit.
>
>  2) It must gracefully degrade across architectures/targets.  Do not 
> assume qemu-system-x86_64 is present or that an arm cross compiler is 
> available.
>
> It would also be nice to get this integrated as part of buildbot. 
> Stefan/Daniel, is that something we can do?
>
> Regards,
>
> Anthony Liguori

Hi,

'make check-quick' sounds unusual for me. I'm not a native speaker,
so I compared the frequency of "check quick" and "quick check"
using Google. 'make quick-check' would sound better, but even
that is a Makefile target which I never saw before.

There is a standard for the commonly used 'make check'
(http://www.gnu.org/prep/standards/html_node/Standard-Targets.html).
I'd stick to that standard and allow users to select the tests
which should be run by Makefile macros. So

     make check-quick

could be replaced by

     make check TESTS=quick

Macro TESTS could be used to select a list of tests, for example
TESTS=tcg,block,pci or TESTS=mips,s390. The supported keywords
should be similar to the keywords used in MAINTAINERS. Then
committers or maintainers can select which tests are needed
for their commits. Other keywords like 'quick' or 'all' select
a predefined subset or all tests, and individual tests can be
specified by some kind of hierarchical name like for example
'pci/net/e1000'.

Regards,
Stefan Weil