From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Sebastian Haas <dev@sebastianhaas.info>
Cc: Stephane Grosjean <s.grosjean@peak-system.com>,
Linux-can Mailing List <linux-can@vger.kernel.org>
Subject: Re: [PATCH] Add PEAK System USB adapters core driver
Date: Tue, 10 Jan 2012 13:53:13 +0100 [thread overview]
Message-ID: <4F0C34B9.4000406@pengutronix.de> (raw)
In-Reply-To: <4EF3A40E.4080206@sebastianhaas.info>
[-- Attachment #1: Type: text/plain, Size: 661 bytes --]
On 12/22/2011 10:41 PM, Sebastian Haas wrote:
> Hi again,
>
> some nitpicking this time. ;-)
>
> You are mixing pr_*, dev_* and netdev_* please check if it is possible
> to harmonize the usage.
I think, that you should use netdev_* whenever you have a netdev
pointer, dev_* until no netdev has been registered and pr_* if not even
a device pointer is available.
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 262 bytes --]
next prev parent reply other threads:[~2012-01-10 12:53 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-22 13:11 [PATCH] Add PEAK System USB adapters core driver Stephane Grosjean
2011-12-22 21:41 ` Sebastian Haas
2011-12-23 9:33 ` Grosjean Stephane
2011-12-23 11:48 ` dev
2012-01-10 12:53 ` Marc Kleine-Budde [this message]
2012-01-10 10:17 ` Wolfgang Grandegger
2012-01-10 15:22 ` Oliver Hartkopp
2012-01-10 15:35 ` Wolfgang Grandegger
2012-01-11 9:23 ` Grosjean Stephane
2012-01-11 9:50 ` Marc Kleine-Budde
2012-01-11 10:09 ` Grosjean Stephane
2012-01-11 10:12 ` Wolfgang Grandegger
2012-01-11 10:29 ` Oliver Hartkopp
2012-01-11 12:28 ` Wolfgang Grandegger
2012-01-11 9:59 ` Wolfgang Grandegger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F0C34B9.4000406@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=dev@sebastianhaas.info \
--cc=linux-can@vger.kernel.org \
--cc=s.grosjean@peak-system.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.