Re: [PATCH] Add PEAK System USB adapters core driver

[Wolfgang Grandegger <wg@grandegger.com>]

On 01/11/2012 11:29 AM, Oliver Hartkopp wrote:
> On 11.01.2012 11:12, Wolfgang Grandegger wrote:
> 
>> On 01/11/2012 10:50 AM, Marc Kleine-Budde wrote:
>>> On 01/11/2012 10:23 AM, Grosjean Stephane wrote:
> 
>>> Documentation/kbuild/makefiles.txt has this example:
>>>
>>> 	obj-$(CONFIG_EXT2_FS) += ext2.o
>>> 	ext2-y := balloc.o dir.o file.o ialloc.o inode.o ioctl.o \
>>> 		namei.o super.o symlink.o
>>> 	ext2-$(CONFIG_EXT2_FS_XATTR) += xattr.o xattr_user.o \
>>> 		xattr_trusted.o
>>>
>>> Which translates into (untested, though):
>>>
>>> 	obj-$(CONFIG_CAN_PEAK_USB) += peak_usb.o
>>> 	peak_usb-y := peak_usb_core.o pcan_usb.o pcan_usb_pro.o
>>>
>>> With a peak_usb_core.c file.
>>
>> I suggested to use peak_usb.c (instead of pcan_core.c) to have a
>> consistent naming (header file and prefix). This seems not to be
>> possible. I was not aware of that. Naming the files peak_usb_core.c and
>> peak_usb_core.h seems a good alternative.
> 
> 
> 
> pcan is the adapter model name and peak is the manufacturer name.
> 
> Then i would suggest to name all building source files with pcan_*
> 
> like:
> 
> pcan_usb_core.c
> pcan_usb_core.h
> pcan_usb.c
> pcan_usb_pro.c
> 
> resulting in a peak_usb.ko

I don't care about the name but it should be used consistently, for the
sake of readability.

Wolfgang.