From: Adrian-Ken Rueegsegger <ken@codelabs.ch>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: herbert@gondor.apana.org.au, linux-crypto@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: sha512: make it work, undo percpu message schedule
Date: Wed, 11 Jan 2012 02:12:48 +0100 [thread overview]
Message-ID: <4F0CE210.1080305@codelabs.ch> (raw)
In-Reply-To: <20120111000040.GA3801@p183.telecom.by>
On 01/11/2012 01:00 AM, Alexey Dobriyan wrote:
> commit f9e2bca6c22d75a289a349f869701214d63b5060
> aka "crypto: sha512 - Move message schedule W[80] to static percpu area"
> created global message schedule area.
[snip]
> I personally don't understand this changelog entry:
>
> "The message schedule W (u64[80]) is too big for the stack."
>
> Hash context is dynamically allocated.
My original patch did the same thing as yours and put the message
schedule on the stack in sha512_transform. Herbert argued [1], that it
was too big and suggested to store it in a static per-cpu area.
[1] - http://www.mail-archive.com/linux-crypto@vger.kernel.org/msg02527.html
prev parent reply other threads:[~2012-01-11 1:18 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-11 0:00 sha512: make it work, undo percpu message schedule Alexey Dobriyan
2012-01-11 0:12 ` Alexey Dobriyan
2012-01-11 0:36 ` Herbert Xu
2012-01-12 23:55 ` Alexey Dobriyan
2012-01-13 0:19 ` Herbert Xu
2012-01-13 7:08 ` Herbert Xu
2012-01-13 10:35 ` Eric Dumazet
2012-01-13 10:41 ` Eric Dumazet
2012-01-13 10:57 ` Eric Dumazet
2012-01-13 11:33 ` Alexey Dobriyan
2012-01-13 12:34 ` Eric Dumazet
2012-01-14 18:20 ` Alexey Dobriyan
2012-01-14 18:27 ` [PATCH 1/3] " Alexey Dobriyan
2012-01-14 18:40 ` [PATCH 2/3] sha512: reduce stack usage to safe number Alexey Dobriyan
2012-01-14 18:44 ` [PATCH 3/3] sha512: use standard ror64() Alexey Dobriyan
2012-01-14 19:08 ` [PATCH 2/3] sha512: reduce stack usage to safe number Linus Torvalds
2012-01-14 20:41 ` Alexey Dobriyan
2012-01-14 21:14 ` Linus Torvalds
2012-01-16 9:56 ` David Laight
2012-01-16 10:20 ` Alexey Dobriyan
2012-01-16 10:23 ` Eric Dumazet
2012-01-16 11:37 ` David Laight
2012-01-17 12:03 ` Alexey Dobriyan
2012-01-18 18:02 ` [PATCH 4/3] sha512: reduce stack usage even on i386 Alexey Dobriyan
2012-01-26 2:35 ` Herbert Xu
2012-01-27 17:51 ` Alexey Dobriyan
2012-01-27 22:32 ` Herbert Xu
2012-01-30 11:10 ` Alexey Dobriyan
2012-02-03 3:34 ` Herbert Xu
2012-01-14 21:46 ` [PATCH 1/3] sha512: make it work, undo percpu message schedule Eric Dumazet
2012-01-14 21:52 ` Linus Torvalds
2012-01-14 22:00 ` Eric Dumazet
2012-01-15 1:43 ` Herbert Xu
2012-01-13 11:02 ` Steffen Klassert
2012-01-15 1:43 ` Herbert Xu
2012-01-13 11:45 ` David Laight
2012-01-13 12:35 ` Eric Dumazet
2012-01-13 6:22 ` Steffen Klassert
2012-01-13 6:46 ` Herbert Xu
2012-01-13 6:48 ` Eric Dumazet
2012-01-13 6:50 ` Herbert Xu
2012-01-13 9:45 ` David Laight
2012-01-11 1:12 ` Adrian-Ken Rueegsegger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F0CE210.1080305@codelabs.ch \
--to=ken@codelabs.ch \
--cc=adobriyan@gmail.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.