From: Evgeny Voevodin <e.voevodin@samsung.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: kyungmin.park@samsung.com, m.kozlov@samsung.com,
jehyung.lee@samsung.com, qemu-devel@nongnu.org,
d.solodkiy@samsung.com
Subject: Re: [Qemu-devel] [PATCH v5 02/11] ARM: exynos4210: UART support
Date: Wed, 11 Jan 2012 09:28:57 +0400 [thread overview]
Message-ID: <4F0D1E19.20308@samsung.com> (raw)
In-Reply-To: <CAFEAcA8c79B3yrD4Z+ug1XHY9Gh78bgsy4+VwocOr6DZ-5OmLg@mail.gmail.com>
On 01/10/2012 04:11 PM, Peter Maydell wrote:
>> + case UINTP:
>> + s->reg[I_(UINTP)]&= ~val;
>> + /* XXX: It's the assumption that it works in this way */
> Can you expand this comment a little to clarify exactly what the
> assumption you're making is?
It was not clear from documentation if UINTSP register bits should be
cleared inside
this "case" too. Practise has showed that should. I think, this comment
message could be removed.
--
Kind regards,
Evgeny Voevodin,
Leading Software Engineer,
ASWG, Moscow R&D center, Samsung Electronics
e-mail: e.voevodin@samsung.com
next prev parent reply other threads:[~2012-01-11 5:29 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-23 11:40 [Qemu-devel] [PATCH v5 00/11] ARM: Samsung Exynos4210-based boards support Evgeny Voevodin
2011-12-23 11:40 ` [Qemu-devel] [PATCH v5 01/11] ARM: Samsung exynos4210-based boards emulation Evgeny Voevodin
2011-12-23 11:40 ` [Qemu-devel] [PATCH v5 02/11] ARM: exynos4210: UART support Evgeny Voevodin
2012-01-10 12:11 ` Peter Maydell
2012-01-11 5:28 ` Evgeny Voevodin [this message]
2011-12-23 11:40 ` [Qemu-devel] [PATCH v5 03/11] hw/sysbus.h: Increase maximum number of device IRQs Evgeny Voevodin
2012-01-10 12:40 ` Peter Maydell
2011-12-23 11:40 ` [Qemu-devel] [PATCH v5 04/11] ARM: exynos4210: IRQ subsystem support Evgeny Voevodin
2012-01-10 12:35 ` Peter Maydell
2011-12-23 11:40 ` [Qemu-devel] [PATCH v5 05/11] ARM: exynos4210: PWM support Evgeny Voevodin
2012-01-10 12:40 ` Peter Maydell
2012-01-10 13:46 ` Andreas Färber
2011-12-23 11:40 ` [Qemu-devel] [PATCH v5 06/11] hw/arm_boot.c: Extend secondary CPU bootloader Evgeny Voevodin
2012-01-10 15:32 ` Peter Maydell
2011-12-23 11:40 ` [Qemu-devel] [PATCH v5 07/11] ARM: exynos4210: MCT support Evgeny Voevodin
2012-01-10 16:13 ` Peter Maydell
2011-12-23 11:40 ` [Qemu-devel] [PATCH v5 08/11] hw/exynos4210.c: Boot secondary CPU Evgeny Voevodin
2012-01-10 16:16 ` Peter Maydell
2012-01-11 6:13 ` Evgeny Voevodin
2011-12-23 11:40 ` [Qemu-devel] [PATCH v5 09/11] hw/lan9118: Add basic 16-bit mode support Evgeny Voevodin
2012-01-10 16:29 ` Peter Maydell
2011-12-23 11:40 ` [Qemu-devel] [PATCH v5 10/11] hw/exynos4210.c: Add LAN support for SMDKC210 Evgeny Voevodin
2012-01-10 16:30 ` Peter Maydell
2011-12-23 11:40 ` [Qemu-devel] [PATCH v5 11/11] Exynos4210: added display controller implementation Evgeny Voevodin
2012-01-10 16:51 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F0D1E19.20308@samsung.com \
--to=e.voevodin@samsung.com \
--cc=d.solodkiy@samsung.com \
--cc=jehyung.lee@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=m.kozlov@samsung.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.