All of lore.kernel.org
 help / color / mirror / Atom feed
From: tangchen <tangchen@cn.fujitsu.com>
To: Lucas Meneghel Rodrigues <lmr@redhat.com>,
	autotest@test.kernel.org, kvm@vger.kernel.org
Subject: [PATCH] libvirt_vm.py:  Set ignore_status to False in virsh_cmd().
Date: Wed, 11 Jan 2012 15:06:48 +0800	[thread overview]
Message-ID: <4F0D3508.3020606@cn.fujitsu.com> (raw)

utils.run()'s parameter "ignore_status" is set to "True" in virsh_cmd(). 
In this case we are not able to know whether the command succeeds. 
This patch sets it to "False", and utils.run() will throw an exception 
when command fails.


Signed-off-by: Tang Chen <tangchen@cn.fujitsu.com>
---
 client/virt/libvirt_vm.py |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/client/virt/libvirt_vm.py b/client/virt/libvirt_vm.py
index c825661..6f30f36 100644
--- a/client/virt/libvirt_vm.py
+++ b/client/virt/libvirt_vm.py
@@ -38,7 +38,7 @@ def virsh_cmd(cmd, uri = ""):
     if uri:
         uri_arg = "-c " + uri
 
-    cmd_result = utils.run("%s %s %s" % (VIRSH_EXEC, uri_arg, cmd), ignore_status=True,
+    cmd_result = utils.run("%s %s %s" % (VIRSH_EXEC, uri_arg, cmd), ignore_status=False,
                            verbose=DEBUG)
     if DEBUG:
         if cmd_result.stdout.strip():
-- 
1.7.3.1


-- 
Best Regards,
Tang chen
--------------------------------------------------
Tang Chen
Development Dept.I
Nanjing Fujitsu Nanda Software Tech. Co., Ltd.(FNST)
No.6 Wenzhu Road, Nanjing, 210012, China 
TEL: +86+25-86630566-8527
FUJITSU INTERNAL: 7998-8527
FAX: +86+25-83317685
EMail: tangchen@cn.fujitsu.com
--------------------------------------------------
This communication is for use by the intended recipient(s) only and may contain information that is privileged, confidential and exempt from disclosure under applicable law. If you are not an intended recipient of this communication, you are hereby notified that any dissemination, distribution or copying hereof is strictly prohibited.  If you have received this communication in error, please notify me by reply e-mail, permanently delete this communication from your system, and destroy any hard copies you may have printed


             reply	other threads:[~2012-01-11  7:20 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-11  7:06 tangchen [this message]
2012-01-12 15:53 ` [PATCH] libvirt_vm.py: Set ignore_status to False in virsh_cmd() Lucas Meneghel Rodrigues

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F0D3508.3020606@cn.fujitsu.com \
    --to=tangchen@cn.fujitsu.com \
    --cc=autotest@test.kernel.org \
    --cc=kvm@vger.kernel.org \
    --cc=lmr@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.