All of lore.kernel.org
 help / color / mirror / Atom feed
From: wmb@firmworks.com (Mitch Bradley)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: vexpress: initial device tree support
Date: Wed, 11 Jan 2012 14:47:27 -1000	[thread overview]
Message-ID: <4F0E2D9F.5080909@firmworks.com> (raw)
In-Reply-To: <4F0E2B95.7070402@firmworks.com>

More nits picked below ...


 >
 > i2c1: i2c at 7000c000 {
 >      #address-cells =<1>;
 >      #size-cells =<0>;
 >      compatible = "nvidia,tegra20-i2c";
 >      reg =<0x7000C000 0x100>;
 >      interrupts =<0 38 0x04>;
 > };
 >
 > mux at 0 {

The name "i2cmux" might be more evocative.

 >      #address-cells =<1>;
 >      #size-cells =<0>;
 >      compatible = "nvidia,tegra20-i2c";
 >      parent-bus =<&i2c1>;
 >      gpios =<&gpio 100 0&gpio 101 0>;
 >      gpio-values-idle =<0>; /* bitmask of values */
 >
 >      bus at 0 {

Since this implements the i2c bus abstraction, the name should be "i2c"

 >          #address-cells =<1>;
 >          #size-cells =<0>;
 >          /*
 >           * The GPIO values to set as a bitmask.
 >           * Formatted like gpio-i2cmux.c's mux->data.values[i].
 >           * Or name this gpio-values?
 >           */
 >          reg =<1>;
 >
 >          wm8903: wm8903 at 1a {
 >              compatible = "wlf,wm8903";
 >              reg =<0x1a>;
 >              ...
 >          };
 >      };
 >
 >      bus at 1 {

Ditto, name should be "i2c"

 >          #address-cells =<1>;
 >          #size-cells =<0>;
 >          reg =<2>;
 >
 >          light-sensor at 44 {
 >              compatible = "isil,isl29018";
 >              reg =<0x44>;
 >              ...
 >          };
 >      };
 > };

WARNING: multiple messages have this Message-ID (diff)
From: Mitch Bradley <wmb-D5eQfiDGL7eakBO8gow8eQ@public.gmane.org>
To: Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Cc: "Paweł Moll" <Pawel.Moll-5wv7dgnIgG8@public.gmane.org>,
	"patches-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org"
	<patches-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
	"devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org"
	<devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org>,
	"Jamie Lokier" <jamie-yetKDKU6eevNLxjTenLetw@public.gmane.org>,
	"Rob Herring"
	<rob.herring-CfjtxxwdHycX+EX/Zwu52A@public.gmane.org>,
	"Timur Tabi" <timur-KZfg59tc24xl57MIdRCFDg@public.gmane.org>,
	"linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org"
	<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>
Subject: Re: [PATCH] ARM: vexpress: initial device tree support
Date: Wed, 11 Jan 2012 14:47:27 -1000	[thread overview]
Message-ID: <4F0E2D9F.5080909@firmworks.com> (raw)
In-Reply-To: <4F0E2B95.7070402-D5eQfiDGL7eakBO8gow8eQ@public.gmane.org>

More nits picked below ...


 >
 > i2c1: i2c@7000c000 {
 >      #address-cells =<1>;
 >      #size-cells =<0>;
 >      compatible = "nvidia,tegra20-i2c";
 >      reg =<0x7000C000 0x100>;
 >      interrupts =<0 38 0x04>;
 > };
 >
 > mux@0 {

The name "i2cmux" might be more evocative.

 >      #address-cells =<1>;
 >      #size-cells =<0>;
 >      compatible = "nvidia,tegra20-i2c";
 >      parent-bus =<&i2c1>;
 >      gpios =<&gpio 100 0&gpio 101 0>;
 >      gpio-values-idle =<0>; /* bitmask of values */
 >
 >      bus@0 {

Since this implements the i2c bus abstraction, the name should be "i2c"

 >          #address-cells =<1>;
 >          #size-cells =<0>;
 >          /*
 >           * The GPIO values to set as a bitmask.
 >           * Formatted like gpio-i2cmux.c's mux->data.values[i].
 >           * Or name this gpio-values?
 >           */
 >          reg =<1>;
 >
 >          wm8903: wm8903@1a {
 >              compatible = "wlf,wm8903";
 >              reg =<0x1a>;
 >              ...
 >          };
 >      };
 >
 >      bus@1 {

Ditto, name should be "i2c"

 >          #address-cells =<1>;
 >          #size-cells =<0>;
 >          reg =<2>;
 >
 >          light-sensor@44 {
 >              compatible = "isil,isl29018";
 >              reg =<0x44>;
 >              ...
 >          };
 >      };
 > };

  reply	other threads:[~2012-01-12  0:47 UTC|newest]

Thread overview: 82+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-21  9:19 [PATCH] ARM: vexpress: initial device tree support Dave Martin
2011-09-21  9:19 ` Dave Martin
2011-09-21 13:24 ` Rob Herring
2011-09-21 13:24   ` Rob Herring
2011-09-21 14:24   ` Dave Martin
2011-09-21 14:24     ` Dave Martin
2011-09-21 14:33     ` Pawel Moll
2011-09-21 14:33       ` Pawel Moll
2011-09-21 15:49       ` Dave Martin
2011-09-21 15:49         ` Dave Martin
2011-09-21 14:57   ` Grant Likely
2011-09-21 14:57     ` Grant Likely
2011-09-21 16:01     ` Pawel Moll
2011-09-21 16:01       ` Pawel Moll
2011-09-21 16:17       ` Dave Martin
2011-09-21 16:17         ` Dave Martin
2011-09-21 16:28         ` Pawel Moll
2011-09-21 16:28           ` Pawel Moll
2011-09-21 16:37     ` Rob Herring
2011-09-21 16:37       ` Rob Herring
2011-09-21 17:15       ` Dave Martin
2011-09-21 17:15         ` Dave Martin
2011-09-21 17:47         ` Mitch Bradley
2011-09-21 17:47           ` Mitch Bradley
2011-09-22 12:19           ` Dave Martin
2011-09-22 12:19             ` Dave Martin
2012-01-09 23:26 ` Tabi Timur-B04825
2012-01-09 23:26   ` Tabi Timur-B04825
2012-01-10  0:42   ` Mitch Bradley
2012-01-10  0:42     ` Mitch Bradley
2012-01-10  2:24     ` Tabi Timur-B04825
2012-01-10  2:24       ` Tabi Timur-B04825
2012-01-10 12:22     ` Jamie Lokier
2012-01-10 12:22       ` Jamie Lokier
2012-01-10 21:58       ` Timur Tabi
2012-01-10 21:58         ` Timur Tabi
2012-01-10 22:35         ` Mitch Bradley
2012-01-10 22:35           ` Mitch Bradley
2012-01-10 23:55           ` Stephen Warren
2012-01-10 23:55             ` Stephen Warren
2012-01-11  0:02             ` Timur Tabi
2012-01-11  0:02               ` Timur Tabi
2012-01-11  0:28           ` Timur Tabi
2012-01-11  0:28             ` Timur Tabi
2012-01-11  6:43             ` Mitch Bradley
2012-01-11  6:43               ` Mitch Bradley
2012-01-11 20:17               ` Timur Tabi
2012-01-11 20:17                 ` Timur Tabi
2012-01-11 23:20                 ` Mitch Bradley
2012-01-11 23:20                   ` Mitch Bradley
2012-01-11 23:32                   ` Timur Tabi
2012-01-11 23:32                     ` Timur Tabi
2012-01-11 20:29               ` Stephen Warren
2012-01-11 20:29                 ` Stephen Warren
2012-01-11 20:32                 ` Timur Tabi
2012-01-11 20:32                   ` Timur Tabi
2012-01-11 20:36                   ` Stephen Warren
2012-01-11 20:36                     ` Stephen Warren
2012-01-11 21:37                     ` Timur Tabi
2012-01-11 21:37                       ` Timur Tabi
2012-01-11 21:57                       ` Stephen Warren
2012-01-11 21:57                         ` Stephen Warren
2012-01-12 12:24                     ` Jamie Lokier
2012-01-12 12:24                       ` Jamie Lokier
2012-01-12 16:49                       ` Stephen Warren
2012-01-12 16:49                         ` Stephen Warren
2012-01-11 23:16                 ` Mitch Bradley
2012-01-11 23:16                   ` Mitch Bradley
2012-01-12  0:15                   ` Stephen Warren
2012-01-12  0:15                     ` Stephen Warren
2012-01-12  0:38                     ` Mitch Bradley
2012-01-12  0:38                       ` Mitch Bradley
2012-01-12  0:47                       ` Mitch Bradley [this message]
2012-01-12  0:47                         ` Mitch Bradley
2012-01-12 16:45                       ` Stephen Warren
2012-01-12 16:45                         ` Stephen Warren
2012-01-12 12:09                     ` Jamie Lokier
2012-01-12 12:09                       ` Jamie Lokier
2012-01-12 16:52                       ` Stephen Warren
2012-01-12 16:52                         ` Stephen Warren
2012-01-10 11:04   ` Dave Martin
2012-01-10 11:04     ` Dave Martin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F0E2D9F.5080909@firmworks.com \
    --to=wmb@firmworks.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.