All of lore.kernel.org
 help / color / mirror / Atom feed
From: Li Zefan <lizf@cn.fujitsu.com>
To: Pekka Enberg <penberg@kernel.org>
Cc: David Rientjes <rientjes@google.com>,
	Sasha Levin <levinsasha928@gmail.com>,
	akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
	linux-mm@kvack.org
Subject: Re: [PATCH] mm: Don't warn if memdup_user fails
Date: Thu, 12 Jan 2012 17:09:59 +0800	[thread overview]
Message-ID: <4F0EA367.8060105@cn.fujitsu.com> (raw)
In-Reply-To: <CAOJsxLGTO8=w8nYADY9hVBs_63UGR-jfrPOYsgexDUo-pPFjDQ@mail.gmail.com>

Pekka Enberg wrote:
> On Thu, Jan 12, 2012 at 8:43 AM, Pekka Enberg <penberg@kernel.org> wrote:
>> Sasha, I suppose strndup_user() has the same kind of issue?
> 
> Oh, it uses memdup_user() internally. Sorry for the noise.
> 

Before memdup_user() was introduced, strndup_user() called kmalloc()
directly, without specifying __GFP_NOWARN.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: Li Zefan <lizf@cn.fujitsu.com>
To: Pekka Enberg <penberg@kernel.org>
Cc: David Rientjes <rientjes@google.com>,
	Sasha Levin <levinsasha928@gmail.com>,
	akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
	linux-mm@kvack.org
Subject: Re: [PATCH] mm: Don't warn if memdup_user fails
Date: Thu, 12 Jan 2012 17:09:59 +0800	[thread overview]
Message-ID: <4F0EA367.8060105@cn.fujitsu.com> (raw)
In-Reply-To: <CAOJsxLGTO8=w8nYADY9hVBs_63UGR-jfrPOYsgexDUo-pPFjDQ@mail.gmail.com>

Pekka Enberg wrote:
> On Thu, Jan 12, 2012 at 8:43 AM, Pekka Enberg <penberg@kernel.org> wrote:
>> Sasha, I suppose strndup_user() has the same kind of issue?
> 
> Oh, it uses memdup_user() internally. Sorry for the noise.
> 

Before memdup_user() was introduced, strndup_user() called kmalloc()
directly, without specifying __GFP_NOWARN.

  reply	other threads:[~2012-01-12  9:07 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-11 16:50 [PATCH] mm: Don't warn if memdup_user fails Sasha Levin
2012-01-11 16:50 ` Sasha Levin
2012-01-11 21:46 ` David Rientjes
2012-01-11 21:46   ` David Rientjes
2012-01-12  6:43   ` Pekka Enberg
2012-01-12  6:43     ` Pekka Enberg
2012-01-12  6:44     ` Pekka Enberg
2012-01-12  6:44       ` Pekka Enberg
2012-01-12  9:09       ` Li Zefan [this message]
2012-01-12  9:09         ` Li Zefan
2012-01-11 22:12 ` Andrew Morton
2012-01-11 22:12   ` Andrew Morton
2012-01-12  7:12   ` Pekka Enberg
2012-01-12  7:12     ` Pekka Enberg
2012-01-12  8:06   ` Sasha Levin
2012-01-12  8:06     ` Sasha Levin
2012-01-12  8:15     ` Pekka Enberg
2012-01-12  8:15       ` Pekka Enberg
2012-01-12 21:19       ` David Rientjes
2012-01-12 21:19         ` David Rientjes
2012-01-12 21:58         ` Andrew Morton
2012-01-12 21:58           ` Andrew Morton
2012-01-12 22:29           ` David Rientjes
2012-01-12 22:29             ` David Rientjes
2012-01-13  7:17           ` Dan Carpenter
2012-01-13  7:36             ` Andrew Morton
2012-01-13  7:36               ` Andrew Morton
2012-01-12 11:16     ` Tyler Hicks

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F0EA367.8060105@cn.fujitsu.com \
    --to=lizf@cn.fujitsu.com \
    --cc=akpm@linux-foundation.org \
    --cc=levinsasha928@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=penberg@kernel.org \
    --cc=rientjes@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.