From: Stefan Weil <sw@weilnetz.de>
To: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
Cc: qemu-trivial@nongnu.org, andrew.zaborowski@intel.com,
qemu-devel@nongnu.org
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH] bt-host: add missing break statement
Date: Thu, 12 Jan 2012 18:44:27 +0100 [thread overview]
Message-ID: <4F0F1BFB.5070509@weilnetz.de> (raw)
In-Reply-To: <1326377824-23776-1-git-send-email-stefanha@linux.vnet.ibm.com>
Am 12.01.2012 15:17, schrieb Stefan Hajnoczi:
> The switch statement in bt_host_read() is missing a break in one case.
> Andrzej Zaborowski <andrew.zaborowski@intel.com> confirmed that this is
> not an intentional fall-through.
>
> Signed-off-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
> ---
> bt-host.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/bt-host.c b/bt-host.c
> index df5b7cd..0d3ad28 100644
> --- a/bt-host.c
> +++ b/bt-host.c
> @@ -130,6 +130,7 @@ static void bt_host_read(void *opaque)
> pktlen = MIN(pkt[2] + 3, s->len);
> s->len -= pktlen;
> pkt += pktlen;
> + break;
>
> default:
> bad_pkt:
Reviewed-by: Stefan Weil <sw@weilnetz.de>
WARNING: multiple messages have this Message-ID (diff)
From: Stefan Weil <sw@weilnetz.de>
To: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
Cc: qemu-trivial@nongnu.org, andrew.zaborowski@intel.com,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] bt-host: add missing break statement
Date: Thu, 12 Jan 2012 18:44:27 +0100 [thread overview]
Message-ID: <4F0F1BFB.5070509@weilnetz.de> (raw)
In-Reply-To: <1326377824-23776-1-git-send-email-stefanha@linux.vnet.ibm.com>
Am 12.01.2012 15:17, schrieb Stefan Hajnoczi:
> The switch statement in bt_host_read() is missing a break in one case.
> Andrzej Zaborowski <andrew.zaborowski@intel.com> confirmed that this is
> not an intentional fall-through.
>
> Signed-off-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
> ---
> bt-host.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/bt-host.c b/bt-host.c
> index df5b7cd..0d3ad28 100644
> --- a/bt-host.c
> +++ b/bt-host.c
> @@ -130,6 +130,7 @@ static void bt_host_read(void *opaque)
> pktlen = MIN(pkt[2] + 3, s->len);
> s->len -= pktlen;
> pkt += pktlen;
> + break;
>
> default:
> bad_pkt:
Reviewed-by: Stefan Weil <sw@weilnetz.de>
next prev parent reply other threads:[~2012-01-12 17:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-12 14:17 [Qemu-trivial] [PATCH] bt-host: add missing break statement Stefan Hajnoczi
2012-01-12 14:17 ` [Qemu-devel] " Stefan Hajnoczi
2012-01-12 17:44 ` Stefan Weil [this message]
2012-01-12 17:44 ` Stefan Weil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F0F1BFB.5070509@weilnetz.de \
--to=sw@weilnetz.de \
--cc=andrew.zaborowski@intel.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=stefanha@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.