From: "Andreas Färber" <afaerber@suse.de>
To: Gerhard Wiesinger <lists@wiesinger.com>
Cc: qemu-devel@nongnu.org, qemu-stable@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] hw/vmmouse.c: Fix to disable vmmouse after reboot
Date: Thu, 12 Jan 2012 19:37:47 +0100 [thread overview]
Message-ID: <4F0F287B.3010009@suse.de> (raw)
In-Reply-To: <4F09C4E9.3010300@suse.de>
Am 08.01.2012 17:31, schrieb Andreas Färber:
> Am 08.01.2012 13:01, schrieb Gerhard Wiesinger:
>> On Wed, 4 Jan 2012, Gerhard Wiesinger wrote:
>>
>>> Testscenario:
>>> 1.) Boot e.g. OS with VMMouse support (e.g. Windows)
>>> 2.) reboot
>>> 3.) Boot e.g. OS without VMMouse support (e.g. DOS) => PS/2 mouse
>>> doesn't work any more. Fixes that issue.
>>>
>>> Reason is that VMMouse has priority and disables all other mouse
>>> entities and therefore must be disabled on reset.
>>
>> Any further comments before integrating the patch?
>
> I implicitly asked you for a more verbose commit message.
>
> For example, based on the info you provided as a reply above:
>
> --8<--
> hw/vmmouse.c: Disable vmmouse on reboot
>
> When a guest activated the vmmouse, following a reboot the vmmouse
> stayed enabled and the PS/2 mouse was unusable. That way, when rebooting
> to guests without vmmouse support the mouse would not work.
>
> Fix this by disabling the vmmouse in its reset handler.
> --8<--
I have been unable to reproduce this issue with our qemu-kvm 0.15.1.
SLES 11 uses vmmouse, whereas SLES installation does not use vmmouse.
After doing a kdump or reboot in SLES, the mouse worked just fine in
either of them.
The patch doesn't break anything for me though.
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
next prev parent reply other threads:[~2012-01-12 18:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-04 16:54 [Qemu-devel] [PATCH] hw/vmmouse.c: Fix to disable vmmouse after reboot Gerhard Wiesinger
2012-01-04 17:10 ` Andreas Färber
2012-01-04 17:25 ` Gerhard Wiesinger
2012-01-08 12:01 ` Gerhard Wiesinger
2012-01-08 16:31 ` Andreas Färber
2012-01-12 18:37 ` Andreas Färber [this message]
2012-01-24 12:14 ` Jan Kiszka
2012-01-25 20:08 ` Gerhard Wiesinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F0F287B.3010009@suse.de \
--to=afaerber@suse.de \
--cc=lists@wiesinger.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.