All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Manuel Stahl <manuel.stahl@iis.fraunhofer.de>
Cc: linux-iio@vger.kernel.org, jic23@cam.ac.uk
Subject: Re: [PATCH 2/3] staging: iio: core: add missing spaces to error output
Date: Thu, 12 Jan 2012 19:32:34 +0000	[thread overview]
Message-ID: <4F0F3552.7070303@kernel.org> (raw)
In-Reply-To: <1326124974-7288-2-git-send-email-manuel.stahl@iis.fraunhofer.de>

Fine.  But while we are here, isn't conventionto have error strings on
one line even if they break the 80 character limit so that they can
be grepped for?  I guess we have two logical parts here, so not too
bad...
> Signed-off-by: Manuel Stahl <manuel.stahl@iis.fraunhofer.de>
Acked-by: Jonathan Cameron <jic23@kernel.org>
> ---
>  drivers/staging/iio/industrialio-buffer.c |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/iio/industrialio-buffer.c b/drivers/staging/iio/industrialio-buffer.c
> index a03a574..f5c4999 100644
> --- a/drivers/staging/iio/industrialio-buffer.c
> +++ b/drivers/staging/iio/industrialio-buffer.c
> @@ -430,7 +430,7 @@ ssize_t iio_buffer_store_enable(struct device *dev,
>  			ret = indio_dev->setup_ops->preenable(indio_dev);
>  			if (ret) {
>  				printk(KERN_ERR
> -				       "Buffer not started:"
> +				       "Buffer not started: "
>  				       "buffer preenable failed\n");
>  				goto error_ret;
>  			}
> @@ -439,7 +439,7 @@ ssize_t iio_buffer_store_enable(struct device *dev,
>  			ret = buffer->access->request_update(buffer);
>  			if (ret) {
>  				printk(KERN_INFO
> -				       "Buffer not started:"
> +				       "Buffer not started: "
>  				       "buffer parameter update failed\n");
>  				goto error_ret;
>  			}
> @@ -468,7 +468,7 @@ ssize_t iio_buffer_store_enable(struct device *dev,
>  			ret = indio_dev->setup_ops->postenable(indio_dev);
>  			if (ret) {
>  				printk(KERN_INFO
> -				       "Buffer not started:"
> +				       "Buffer not started: "
>  				       "postenable failed\n");
>  				if (buffer->access->unmark_in_use)
>  					buffer->access->unmark_in_use(buffer);

  reply	other threads:[~2012-01-12 19:32 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-09 16:02 [PATCH 1/3] staging: iio: core: fix argument of iio_buffer_register (must be const) Manuel Stahl
2012-01-09 16:02 ` [PATCH 2/3] staging: iio: core: add missing spaces to error output Manuel Stahl
2012-01-12 19:32   ` Jonathan Cameron [this message]
2012-01-09 16:02 ` [PATCH 3/3] staging: iio: core: add error message when buffer length is zero Manuel Stahl
2012-01-12 19:35   ` Jonathan Cameron
2012-01-12 19:31 ` [PATCH 1/3] staging: iio: core: fix argument of iio_buffer_register (must be const) Jonathan Cameron
2012-01-12 19:32   ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F0F3552.7070303@kernel.org \
    --to=jic23@kernel.org \
    --cc=jic23@cam.ac.uk \
    --cc=linux-iio@vger.kernel.org \
    --cc=manuel.stahl@iis.fraunhofer.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.