All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Manuel Stahl <manuel.stahl@iis.fraunhofer.de>
Cc: linux-iio@vger.kernel.org, jic23@cam.ac.uk
Subject: Re: [PATCH 1/3] staging: iio: core: fix argument of iio_buffer_register (must be const)
Date: Thu, 12 Jan 2012 19:32:58 +0000	[thread overview]
Message-ID: <4F0F356A.9000109@kernel.org> (raw)
In-Reply-To: <4F0F34F4.9070108@kernel.org>

On 01/12/2012 07:31 PM, Jonathan Cameron wrote:
> Oops. One trivial point here.  Perhaps the commit message could make it
> clear that this is for the stub?  Had me briefly confused.  Either way
> fine with me.
> 
> On 01/09/2012 04:02 PM, Manuel Stahl wrote:
>> Signed-off-by: Manuel Stahl <manuel.stahl@iis.fraunhofer.de>
> Acked-by: Jonathan Cameron <jic23@cam.ac.uk>
Sorry, finger memory.
Acked-by: Jonathan Cameron <jic23@kernel.org>
>> ---
>>  drivers/staging/iio/buffer.h |    4 ++--
>>  1 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/staging/iio/buffer.h b/drivers/staging/iio/buffer.h
>> index 44593b2..1a35006 100644
>> --- a/drivers/staging/iio/buffer.h
>> +++ b/drivers/staging/iio/buffer.h
>> @@ -197,8 +197,8 @@ int iio_sw_buffer_preenable(struct iio_dev *indio_dev);
>>  #else /* CONFIG_IIO_BUFFER */
>>  
>>  static inline int iio_buffer_register(struct iio_dev *indio_dev,
>> -					   struct iio_chan_spec *channels,
>> -					   int num_channels)
>> +				      const struct iio_chan_spec *channels,
>> +				      int num_channels)
>>  {
>>  	return 0;
>>  }
> 

      reply	other threads:[~2012-01-12 19:32 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-09 16:02 [PATCH 1/3] staging: iio: core: fix argument of iio_buffer_register (must be const) Manuel Stahl
2012-01-09 16:02 ` [PATCH 2/3] staging: iio: core: add missing spaces to error output Manuel Stahl
2012-01-12 19:32   ` Jonathan Cameron
2012-01-09 16:02 ` [PATCH 3/3] staging: iio: core: add error message when buffer length is zero Manuel Stahl
2012-01-12 19:35   ` Jonathan Cameron
2012-01-12 19:31 ` [PATCH 1/3] staging: iio: core: fix argument of iio_buffer_register (must be const) Jonathan Cameron
2012-01-12 19:32   ` Jonathan Cameron [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F0F356A.9000109@kernel.org \
    --to=jic23@kernel.org \
    --cc=jic23@cam.ac.uk \
    --cc=linux-iio@vger.kernel.org \
    --cc=manuel.stahl@iis.fraunhofer.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.