All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ben Greear <greearb@candelatech.com>
To: ath9k-devel@lists.ath9k.org
Subject: [ath9k-devel] Question on keycache size.
Date: Thu, 12 Jan 2012 12:34:06 -0800	[thread overview]
Message-ID: <4F0F43BE.3080108@candelatech.com> (raw)
In-Reply-To: <4F0F3F0B.1010101@candelatech.com>

Here's a bit that looks questionable to me.  This is from
ath9k_rx_skb_postprocess

I'm thinking maybe that else clause should not re-assign
keyix if keyix is RXKEYIX_INVALID (and never set the RX_FLAG_DECRYPTED
flag in rxs->flag?

	if (!(keyix == ATH9K_RXKEYIX_INVALID) && !decrypt_error &&
	    ieee80211_has_protected(fc)) {
		rxs->flag |= RX_FLAG_DECRYPTED;
	} else if (ieee80211_has_protected(fc)
		   && !decrypt_error && skb->len >= hdrlen + 4) {
		keyix = skb->data[hdrlen + 3] >> 6;

		if (test_bit(keyix, common->keymap))
			rxs->flag |= RX_FLAG_DECRYPTED;
	}

Thanks,
Ben

-- 
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc  http://www.candelatech.com

  reply	other threads:[~2012-01-12 20:34 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-11 21:55 [ath9k-devel] Question on keycache size Ben Greear
2012-01-12  8:27 ` Mohammed Shafi
2012-01-12 16:02   ` Ben Greear
2012-01-12 19:46     ` Adrian Chadd
2012-01-12 20:14       ` Ben Greear
2012-01-12 20:34         ` Ben Greear [this message]
2012-01-12 23:11           ` Ben Greear
2012-01-12 23:53             ` Adrian Chadd
2012-01-12 23:59               ` Ben Greear

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F0F43BE.3080108@candelatech.com \
    --to=greearb@candelatech.com \
    --cc=ath9k-devel@lists.ath9k.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.