From: Hannes Reinecke <hare@suse.de>
To: Mike Christie <michaelc@cs.wisc.edu>
Cc: Rob Evers <revers@redhat.com>, linux-scsi@vger.kernel.org
Subject: Re: [PATCH] delay transition requeues for 2 seconds - alua
Date: Thu, 12 Jan 2012 23:13:43 +0100 [thread overview]
Message-ID: <4F0F5B17.3090606@suse.de> (raw)
In-Reply-To: <4F0F3BB1.7090902@cs.wisc.edu>
On 01/12/2012 08:59 PM, Mike Christie wrote:
> On 01/12/2012 01:54 PM, Mike Christie wrote:
>> alua_check_sense will return ADD_TO_MLQUEUE_DELAY then scsi_check_sense
>> will pass that up and scsi_decide_disposition will return that right
>> away.
>
> I mean it is one of those weird ones where we do not do the goto
> maybe_retry in scsi_decide_disposition, so we do not see the fast fail
> bit set. This happens for ADD_TO_MLQUEUE_DELAY and ADD_TO_MLQUEUE.
>
Hmm. Not sure here.
With the above reasoning SG_IO would be retried, too.
Which it most definitely isn't.
I'll be digging deeper here tomorrow.
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
hare@suse.de +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Markus Rex, HRB 16746 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2012-01-12 20:13 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-03 19:20 [PATCH] delay transition requeues for 2 seconds - alua Rob Evers
2012-01-07 15:06 ` Rob Evers
2012-04-25 22:16 ` Rob Evers
2012-01-12 9:43 ` Hannes Reinecke
2012-01-12 17:03 ` Rob Evers
2012-01-12 21:23 ` Hannes Reinecke
2012-01-12 19:54 ` Mike Christie
2012-01-12 19:59 ` Mike Christie
2012-01-12 22:13 ` Hannes Reinecke [this message]
2012-01-13 17:51 ` Rob Evers
2012-02-10 20:04 ` Rob Evers
-- strict thread matches above, loose matches on Subject: below --
2011-12-13 22:40 Rob Evers
2011-12-20 15:41 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F0F5B17.3090606@suse.de \
--to=hare@suse.de \
--cc=linux-scsi@vger.kernel.org \
--cc=michaelc@cs.wisc.edu \
--cc=revers@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.