Re: [PATCH] delay transition requeues for 2 seconds - alua

[Rob Evers <revers@redhat.com>]

On 01/12/2012 05:13 PM, Hannes Reinecke wrote:
> On 01/12/2012 08:59 PM, Mike Christie wrote:
>> On 01/12/2012 01:54 PM, Mike Christie wrote:
>>> alua_check_sense will return ADD_TO_MLQUEUE_DELAY then scsi_check_sense
>>> will pass that up and scsi_decide_disposition will return that right
>>> away.
>>
>> I mean it is one of those weird ones where we do not do the goto
>> maybe_retry in scsi_decide_disposition, so we do not see the fast fail
>> bit set. This happens for ADD_TO_MLQUEUE_DELAY and ADD_TO_MLQUEUE.
>>
> Hmm. Not sure here.
> With the above reasoning SG_IO would be retried, too.
> Which it most definitely isn't.
>
> I'll be digging deeper here tomorrow.
>
> Cheers,
>
> Hannes

Hannes,

I ran some tests today to verify what you said about rtpg not ending
up executing the ADD_TO_MLQUEUE_DELAY path via scsi_softirq_done.

So yes, looks like another delay is required in alua_rtpg.

Rob