From: "Andreas Färber" <afaerber@suse.de>
To: Anthony Liguori <aliguori@us.ibm.com>
Cc: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] build: fix target_phys_addr_t to 64-bit
Date: Fri, 13 Jan 2012 00:47:28 +0100 [thread overview]
Message-ID: <4F0F7110.8090100@suse.de> (raw)
In-Reply-To: <4F0F652E.6010307@us.ibm.com>
Am 12.01.2012 23:56, schrieb Anthony Liguori:
> On 01/12/2012 04:46 PM, Peter Maydell wrote:
> I think a reasonable thing to do is:
>
> #define PRIp64 "0x%08" PRIx64
>
> s:TARGET_FMT_plx:PRIp64:g
Nack, that is unreasonable naming and does not solve the issue pointed
out by Peter. PRI* should never include % or width specifier or prefix.
What we should IMO do is:
#define PRIdPLX PRId64
#define PRIxPLX PRIx64
#define PRIXPLX PRIX64
/* or TARGET_PRI*PHYS or whatever */
This can then be used as "... %02" PRIxPLX for shortened output.
And leave TARGET_FMT_plx untouched except for having it reuse PRIxPLX.
You might want to compare OpenBIOS code, where we've been through that
trouble before.
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
next prev parent reply other threads:[~2012-01-12 23:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-12 17:54 [Qemu-devel] [PATCH] build: fix target_phys_addr_t to 64-bit Anthony Liguori
2012-01-12 18:51 ` Andreas Färber
2012-01-12 20:06 ` Peter Maydell
2012-01-12 20:32 ` Anthony Liguori
2012-01-12 22:42 ` Peter Maydell
2012-01-12 22:46 ` Peter Maydell
2012-01-12 22:56 ` Anthony Liguori
2012-01-12 23:29 ` Peter Maydell
2012-01-12 23:47 ` Andreas Färber [this message]
2012-01-13 1:13 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F0F7110.8090100@suse.de \
--to=afaerber@suse.de \
--cc=aliguori@us.ibm.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.