All of lore.kernel.org
 help / color / mirror / Atom feed
From: HAYASAKA Mitsuo <mitsuo.hayasaka.hu@hitachi.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Alex Elder <elder@kernel.org>,
	yrl.pp-manager.tt@hitachi.com, linux-kernel@vger.kernel.org,
	xfs@oss.sgi.com, xfs-masters@oss.sgi.com, Ben Myers <bpm@sgi.com>,
	Alex Elder <aelder@sgi.com>
Subject: Re: [RFC PATCH] xfs: show uuid when mount fails due to duplicate uuid
Date: Fri, 13 Jan 2012 11:46:52 +0900	[thread overview]
Message-ID: <4F0F9B1C.3050206@hitachi.com> (raw)
In-Reply-To: <20120112161410.GA3810@infradead.org>

Hi Christoph,

Thank you for your comment.

(2012/01/13 1:14), Christoph Hellwig wrote:
> On Thu, Jan 12, 2012 at 11:47:20AM +0900, Mitsuo Hayasaka wrote:
>> When a system tries to mount a filesystem (FS) using UUID, the xfs
>> returns -EINVAL and shows a message if a FS with the same UUID has
>> been already mounted. It is useful to output the duplicate UUID
>> with it.
> 
> Looks good to me,
> 
> 
> Reviewed-by: Christoph Hellwig <hch@lst.de>
> 
>> -	xfs_warn(mp, "Filesystem has duplicate UUID - can't mount");
>> +	xfs_warn(mp,
>> +		"Filesystem has duplicate UUID - can't mount: uuid = %pU",
>> +		uuid);
> 
> Maybe we could write this a bit nicer as:
> 
> 	xfs_warn(mp, "Filesystem has duplicate UUID %p - can't mount", uuid);
> 

It looks nice.
I will send the revised patch soon.

Thanks.

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

WARNING: multiple messages have this Message-ID (diff)
From: HAYASAKA Mitsuo <mitsuo.hayasaka.hu@hitachi.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Ben Myers <bpm@sgi.com>, Alex Elder <aelder@sgi.com>,
	Alex Elder <elder@kernel.org>,
	linux-kernel@vger.kernel.org, xfs@oss.sgi.com,
	xfs-masters@oss.sgi.com, yrl.pp-manager.tt@hitachi.com
Subject: Re: [RFC PATCH] xfs: show uuid when mount fails due to duplicate uuid
Date: Fri, 13 Jan 2012 11:46:52 +0900	[thread overview]
Message-ID: <4F0F9B1C.3050206@hitachi.com> (raw)
In-Reply-To: <20120112161410.GA3810@infradead.org>

Hi Christoph,

Thank you for your comment.

(2012/01/13 1:14), Christoph Hellwig wrote:
> On Thu, Jan 12, 2012 at 11:47:20AM +0900, Mitsuo Hayasaka wrote:
>> When a system tries to mount a filesystem (FS) using UUID, the xfs
>> returns -EINVAL and shows a message if a FS with the same UUID has
>> been already mounted. It is useful to output the duplicate UUID
>> with it.
> 
> Looks good to me,
> 
> 
> Reviewed-by: Christoph Hellwig <hch@lst.de>
> 
>> -	xfs_warn(mp, "Filesystem has duplicate UUID - can't mount");
>> +	xfs_warn(mp,
>> +		"Filesystem has duplicate UUID - can't mount: uuid = %pU",
>> +		uuid);
> 
> Maybe we could write this a bit nicer as:
> 
> 	xfs_warn(mp, "Filesystem has duplicate UUID %p - can't mount", uuid);
> 

It looks nice.
I will send the revised patch soon.

Thanks.

  reply	other threads:[~2012-01-13  2:47 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-12  2:47 [RFC PATCH] xfs: show uuid when mount fails due to duplicate uuid Mitsuo Hayasaka
2012-01-12  2:47 ` Mitsuo Hayasaka
2012-01-12 16:14 ` Christoph Hellwig
2012-01-12 16:14   ` Christoph Hellwig
2012-01-13  2:46   ` HAYASAKA Mitsuo [this message]
2012-01-13  2:46     ` HAYASAKA Mitsuo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F0F9B1C.3050206@hitachi.com \
    --to=mitsuo.hayasaka.hu@hitachi.com \
    --cc=aelder@sgi.com \
    --cc=bpm@sgi.com \
    --cc=elder@kernel.org \
    --cc=hch@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=xfs-masters@oss.sgi.com \
    --cc=xfs@oss.sgi.com \
    --cc=yrl.pp-manager.tt@hitachi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.