From: David Vrabel <david.vrabel@citrix.com>
To: Wei Liu <wei.liu2@citrix.com>
Cc: <ian.campbell@citrix.com>, <konrad.wilk@oracle.com>,
<xen-devel@lists.xensource.com>, <netdev@vger.kernel.org>
Subject: Re: [Xen-devel] [RFC PATCH 3/6] netback: switch to NAPI + kthread model
Date: Fri, 13 Jan 2012 18:21:25 +0000 [thread overview]
Message-ID: <4F107625.7090601@citrix.com> (raw)
In-Reply-To: <1326473949-22389-4-git-send-email-wei.liu2@citrix.com>
On 13/01/12 16:59, Wei Liu wrote:
> This patch implements 1:1 model netback. We utilizes NAPI and kthread
> to do the weight-lifting job:
>
> - NAPI is used for guest side TX (host side RX)
> - kthread is used for guest side RX (host side TX)
>
> This model provides better scheduling fairness among vifs. It also
> lays the foundation for future work.
>
> The major defect for the current implementation is that in the NAPI
> poll handler we don't actually disable interrupt. Xen stuff is
> different from real hardware, it requires some other tuning of ring
> macros.
RING_FINAL_CHECK_FOR_REQUESTS() looks it does the correct thing to me.
David
WARNING: multiple messages have this Message-ID (diff)
From: David Vrabel <david.vrabel@citrix.com>
To: Wei Liu <wei.liu2@citrix.com>
Cc: ian.campbell@citrix.com, konrad.wilk@oracle.com,
xen-devel@lists.xensource.com, netdev@vger.kernel.org
Subject: Re: [Xen-devel] [RFC PATCH 3/6] netback: switch to NAPI + kthread model
Date: Fri, 13 Jan 2012 18:21:25 +0000 [thread overview]
Message-ID: <4F107625.7090601@citrix.com> (raw)
In-Reply-To: <1326473949-22389-4-git-send-email-wei.liu2@citrix.com>
On 13/01/12 16:59, Wei Liu wrote:
> This patch implements 1:1 model netback. We utilizes NAPI and kthread
> to do the weight-lifting job:
>
> - NAPI is used for guest side TX (host side RX)
> - kthread is used for guest side RX (host side TX)
>
> This model provides better scheduling fairness among vifs. It also
> lays the foundation for future work.
>
> The major defect for the current implementation is that in the NAPI
> poll handler we don't actually disable interrupt. Xen stuff is
> different from real hardware, it requires some other tuning of ring
> macros.
RING_FINAL_CHECK_FOR_REQUESTS() looks it does the correct thing to me.
David
next prev parent reply other threads:[~2012-01-13 18:21 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-13 16:59 [RFC PATCH] New Xen netback implementation Wei Liu
2012-01-13 16:59 ` [RFC PATCH 1/6] netback: page pool version 1 Wei Liu
2012-01-13 17:37 ` Konrad Rzeszutek Wilk
2012-01-16 9:31 ` Wei Liu
2012-01-16 9:31 ` Wei Liu
2012-01-13 16:59 ` [RFC PATCH 2/6] netback: add module unload function Wei Liu
2012-01-13 17:57 ` [Xen-devel] " David Vrabel
2012-01-16 9:31 ` Wei Liu
2012-01-16 9:31 ` Wei Liu
2012-01-13 18:47 ` David Vrabel
2012-01-13 16:59 ` [RFC PATCH 3/6] netback: switch to NAPI + kthread model Wei Liu
2012-01-13 18:21 ` David Vrabel [this message]
2012-01-13 18:21 ` [Xen-devel] " David Vrabel
2012-01-16 9:33 ` Wei Liu
2012-01-16 9:33 ` Wei Liu
2012-01-16 10:45 ` Ian Campbell
2012-01-16 10:49 ` Wei Liu
2012-01-16 10:49 ` Wei Liu
2012-01-16 10:56 ` Paul Durrant
2012-01-16 11:09 ` Ian Campbell
2012-01-16 11:46 ` David Vrabel
2012-01-16 10:14 ` Paul Durrant
2012-01-16 10:14 ` Paul Durrant
2012-01-16 10:31 ` Ian Campbell
2012-01-13 16:59 ` [RFC PATCH 4/6] netback: add module get/put operations along with vif connect/disconnect Wei Liu
2012-01-13 18:44 ` [Xen-devel] " David Vrabel
2012-01-16 9:43 ` Wei Liu
2012-01-16 9:43 ` Wei Liu
2012-01-13 16:59 ` [RFC PATCH 5/6] netback: melt xen_netbk into xenvif Wei Liu
2012-01-13 16:59 ` [RFC PATCH 6/6] netback: alter internal function/structure names Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F107625.7090601@citrix.com \
--to=david.vrabel@citrix.com \
--cc=ian.campbell@citrix.com \
--cc=konrad.wilk@oracle.com \
--cc=netdev@vger.kernel.org \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.