From: Avi Kivity <avi@redhat.com>
To: Vasilis Liaskovitis <vasilis.liaskovitis@profitbricks.com>
Cc: kvm@vger.kernel.org, gleb@redhat.com, seabios@seabios.org,
qemu-devel@nongnu.org, kernelfans@gmail.com,
yamahata@valinux.co.jp
Subject: Re: [PATCH 2/3] acpi_piix4: Add stub functions for CPU eject callback
Date: Sun, 15 Jan 2012 14:38:52 +0200 [thread overview]
Message-ID: <4F12C8DC.40301@redhat.com> (raw)
In-Reply-To: <1326453092-4256-3-git-send-email-vasilis.liaskovitis@profitbricks.com>
On 01/13/2012 01:11 PM, Vasilis Liaskovitis wrote:
> Signed-off-by: Vasilis Liaskovitis <vasilis.liaskovitis@profitbricks.com>
> ---
> hw/acpi_piix4.c | 15 +++++++++++++++
> 1 files changed, 15 insertions(+), 0 deletions(-)
>
> diff --git a/hw/acpi_piix4.c b/hw/acpi_piix4.c
> index d5743b6..8bf30dd 100644
> --- a/hw/acpi_piix4.c
> +++ b/hw/acpi_piix4.c
> @@ -37,6 +37,7 @@
>
> #define GPE_BASE 0xafe0
> #define PROC_BASE 0xaf00
> +#define PROC_EJ_BASE 0xaf20
>
We're adding stuff to piix4 which was never there. At a minimum this
needs to be documented. Also needs to be -M pc-1.1 and later only.
--
error compiling committee.c: too many arguments to function
WARNING: multiple messages have this Message-ID (diff)
From: Avi Kivity <avi@redhat.com>
To: Vasilis Liaskovitis <vasilis.liaskovitis@profitbricks.com>
Cc: kvm@vger.kernel.org, gleb@redhat.com, seabios@seabios.org,
qemu-devel@nongnu.org, kernelfans@gmail.com,
yamahata@valinux.co.jp
Subject: Re: [Qemu-devel] [PATCH 2/3] acpi_piix4: Add stub functions for CPU eject callback
Date: Sun, 15 Jan 2012 14:38:52 +0200 [thread overview]
Message-ID: <4F12C8DC.40301@redhat.com> (raw)
In-Reply-To: <1326453092-4256-3-git-send-email-vasilis.liaskovitis@profitbricks.com>
On 01/13/2012 01:11 PM, Vasilis Liaskovitis wrote:
> Signed-off-by: Vasilis Liaskovitis <vasilis.liaskovitis@profitbricks.com>
> ---
> hw/acpi_piix4.c | 15 +++++++++++++++
> 1 files changed, 15 insertions(+), 0 deletions(-)
>
> diff --git a/hw/acpi_piix4.c b/hw/acpi_piix4.c
> index d5743b6..8bf30dd 100644
> --- a/hw/acpi_piix4.c
> +++ b/hw/acpi_piix4.c
> @@ -37,6 +37,7 @@
>
> #define GPE_BASE 0xafe0
> #define PROC_BASE 0xaf00
> +#define PROC_EJ_BASE 0xaf20
>
We're adding stuff to piix4 which was never there. At a minimum this
needs to be documented. Also needs to be -M pc-1.1 and later only.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2012-01-15 12:38 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-13 11:11 [PATCH 0/3] acpi_piix4: Add CPU eject handling Vasilis Liaskovitis
2012-01-13 11:11 ` [Qemu-devel] " Vasilis Liaskovitis
2012-01-13 11:11 ` [PATCH 1/3][Seabios] Add bitmap for cpu _EJ0 callback Vasilis Liaskovitis
2012-01-13 11:11 ` [Qemu-devel] " Vasilis Liaskovitis
2012-01-14 0:27 ` Kevin O'Connor
2012-01-14 0:27 ` [Qemu-devel] " Kevin O'Connor
2012-01-16 11:33 ` Vasilis Liaskovitis
2012-01-16 11:33 ` [Qemu-devel] " Vasilis Liaskovitis
2012-01-19 14:02 ` Vasilis Liaskovitis
2012-01-19 14:02 ` [Qemu-devel] " Vasilis Liaskovitis
2012-01-20 1:08 ` Kevin O'Connor
2012-01-20 1:08 ` [Qemu-devel] " Kevin O'Connor
2012-01-13 11:11 ` [PATCH 2/3] acpi_piix4: Add stub functions for CPU eject callback Vasilis Liaskovitis
2012-01-13 11:11 ` [Qemu-devel] " Vasilis Liaskovitis
2012-01-15 12:38 ` Avi Kivity [this message]
2012-01-15 12:38 ` Avi Kivity
2012-01-16 11:32 ` Vasilis Liaskovitis
2012-01-16 11:32 ` [Qemu-devel] " Vasilis Liaskovitis
2012-01-16 12:26 ` Avi Kivity
2012-01-16 12:26 ` [Qemu-devel] " Avi Kivity
2012-01-13 11:11 ` [PATCH 3/3] acpi_piix4: Call KVM_SETSTATE_VCPU ioctl on cpu ejection Vasilis Liaskovitis
2012-01-13 11:11 ` [Qemu-devel] " Vasilis Liaskovitis
2012-01-13 11:58 ` Jan Kiszka
2012-01-13 11:58 ` [Qemu-devel] " Jan Kiszka
2012-01-13 12:48 ` Vasilis Liaskovitis
2012-01-13 12:48 ` [Qemu-devel] " Vasilis Liaskovitis
2012-01-13 11:58 ` [PATCH 0/3] acpi_piix4: Add CPU eject handling Jan Kiszka
2012-01-13 11:58 ` [Qemu-devel] " Jan Kiszka
2012-01-13 12:49 ` Vasilis Liaskovitis
2012-01-13 12:49 ` [Qemu-devel] " Vasilis Liaskovitis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F12C8DC.40301@redhat.com \
--to=avi@redhat.com \
--cc=gleb@redhat.com \
--cc=kernelfans@gmail.com \
--cc=kvm@vger.kernel.org \
--cc=qemu-devel@nongnu.org \
--cc=seabios@seabios.org \
--cc=vasilis.liaskovitis@profitbricks.com \
--cc=yamahata@valinux.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.