From: Deepthi Dharwar <deepthi@linux.vnet.ibm.com>
To: jhbird.choi@samsung.com
Cc: linux-kernel@vger.kernel.org, Kevin Hilman <khilman@ti.com>,
Len Brown <len.brown@intel.com>,
Trinabh Gupta <g.trinabh@gmail.com>,
Arjan van de Ven <arjan@linux.intel.com>
Subject: Re: [PATCH] cpuidle: fix an incorrect NULL pointer check
Date: Mon, 16 Jan 2012 16:43:06 +0530 [thread overview]
Message-ID: <4F140642.6060105@linux.vnet.ibm.com> (raw)
In-Reply-To: <1326494567-579-1-git-send-email-jhbird.choi@samsung.com>
On 01/14/2012 04:12 AM, jhbird.choi@samsung.com wrote:
> From: Jonghwan Choi <jhbird.choi@samsung.com>
>
> "cpu_dev" should be checked instead of "dev".
>
> Signed-off-by: Jonghwan Choi <jhbird.choi@samsung.com>
> ---
> drivers/cpuidle/cpuidle.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/cpuidle/cpuidle.c b/drivers/cpuidle/cpuidle.c
> index 59f4261..7771810 100644
> --- a/drivers/cpuidle/cpuidle.c
> +++ b/drivers/cpuidle/cpuidle.c
> @@ -294,7 +294,7 @@ static int __cpuidle_register_device(struct cpuidle_device *dev)
> struct device *cpu_dev = get_cpu_device((unsigned long)dev->cpu);
> struct cpuidle_driver *cpuidle_driver = cpuidle_get_driver();
>
> - if (!dev)
> + if (!cpu_dev)
> return -EINVAL;
> if (!try_module_get(cpuidle_driver->owner))
> return -EINVAL;
Reviewed-by: Deepthi Dharwar <deepthi@linux.vnet.ibm.com>
Cheers
Deepthi
prev parent reply other threads:[~2012-01-16 11:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-13 22:42 [PATCH] cpuidle: fix an incorrect NULL pointer check jhbird.choi
2012-01-16 11:13 ` Deepthi Dharwar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F140642.6060105@linux.vnet.ibm.com \
--to=deepthi@linux.vnet.ibm.com \
--cc=arjan@linux.intel.com \
--cc=g.trinabh@gmail.com \
--cc=jhbird.choi@samsung.com \
--cc=khilman@ti.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.