* [PATCH] cpuidle: fix an incorrect NULL pointer check
@ 2012-01-13 22:42 jhbird.choi
2012-01-16 11:13 ` Deepthi Dharwar
0 siblings, 1 reply; 2+ messages in thread
From: jhbird.choi @ 2012-01-13 22:42 UTC (permalink / raw)
To: linux-kernel
Cc: Kevin Hilman, Len Brown, Trinabh Gupta, Arjan van de Ven,
Deepthi Dharwar, Jonghwan Choi
From: Jonghwan Choi <jhbird.choi@samsung.com>
"cpu_dev" should be checked instead of "dev".
Signed-off-by: Jonghwan Choi <jhbird.choi@samsung.com>
---
drivers/cpuidle/cpuidle.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/cpuidle/cpuidle.c b/drivers/cpuidle/cpuidle.c
index 59f4261..7771810 100644
--- a/drivers/cpuidle/cpuidle.c
+++ b/drivers/cpuidle/cpuidle.c
@@ -294,7 +294,7 @@ static int __cpuidle_register_device(struct cpuidle_device *dev)
struct device *cpu_dev = get_cpu_device((unsigned long)dev->cpu);
struct cpuidle_driver *cpuidle_driver = cpuidle_get_driver();
- if (!dev)
+ if (!cpu_dev)
return -EINVAL;
if (!try_module_get(cpuidle_driver->owner))
return -EINVAL;
--
1.7.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] cpuidle: fix an incorrect NULL pointer check
2012-01-13 22:42 [PATCH] cpuidle: fix an incorrect NULL pointer check jhbird.choi
@ 2012-01-16 11:13 ` Deepthi Dharwar
0 siblings, 0 replies; 2+ messages in thread
From: Deepthi Dharwar @ 2012-01-16 11:13 UTC (permalink / raw)
To: jhbird.choi
Cc: linux-kernel, Kevin Hilman, Len Brown, Trinabh Gupta,
Arjan van de Ven
On 01/14/2012 04:12 AM, jhbird.choi@samsung.com wrote:
> From: Jonghwan Choi <jhbird.choi@samsung.com>
>
> "cpu_dev" should be checked instead of "dev".
>
> Signed-off-by: Jonghwan Choi <jhbird.choi@samsung.com>
> ---
> drivers/cpuidle/cpuidle.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/cpuidle/cpuidle.c b/drivers/cpuidle/cpuidle.c
> index 59f4261..7771810 100644
> --- a/drivers/cpuidle/cpuidle.c
> +++ b/drivers/cpuidle/cpuidle.c
> @@ -294,7 +294,7 @@ static int __cpuidle_register_device(struct cpuidle_device *dev)
> struct device *cpu_dev = get_cpu_device((unsigned long)dev->cpu);
> struct cpuidle_driver *cpuidle_driver = cpuidle_get_driver();
>
> - if (!dev)
> + if (!cpu_dev)
> return -EINVAL;
> if (!try_module_get(cpuidle_driver->owner))
> return -EINVAL;
Reviewed-by: Deepthi Dharwar <deepthi@linux.vnet.ibm.com>
Cheers
Deepthi
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-01-16 11:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-01-13 22:42 [PATCH] cpuidle: fix an incorrect NULL pointer check jhbird.choi
2012-01-16 11:13 ` Deepthi Dharwar
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.