All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mike Dunn <mikedunn@newsguy.com>
To: Robert Jarzmik <robert.jarzmik@free.fr>
Cc: linux-mtd@lists.infradead.org, dedekind1@gmail.com
Subject: Re: [PATCH v4] MTD: nand: add support for diskonchip G4 nand flash device
Date: Mon, 16 Jan 2012 11:13:54 -0800	[thread overview]
Message-ID: <4F1476F2.7040800@newsguy.com> (raw)
In-Reply-To: <87y5t9xm0r.fsf@free.fr>

On 01/15/2012 03:06 AM, Robert Jarzmik wrote:
> I looked through. It looks good to me.


Thanks again Robert.


> I have one warning remaining (on top of Linus tree):
> drivers/mtd/nand/docg4.c: In function '__check_ignore_badblocks':
> drivers/mtd/nand/docg4.c:52: warning: return from incompatible pointer type


Ha! This is the result of a patch to moduleparam.h that just went in on Friday
(commit 72db395ffadb1d33233fd123c2bf87ba0198c6c1)

According to Rusty Russell, this will soon become a hard error.


>
> My feeling is that the driver is good to be sent upstream, with my:
> Reviewed-by: Robert Jarzmik <robert.jarzmik@free.fr>
>
> If anything comes up, it can be fixed later, and I think we should go forward.


I'd like to resubmit the patch to fix the warning.  Alternatively, I can follow
up with a separate patch once this one is pushed if the maintainers prefer.

Thanks,
Mike

  reply	other threads:[~2012-01-16 19:14 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-04  0:05 [PATCH v4] MTD: nand: add support for diskonchip G4 nand flash device Mike Dunn
2012-01-04  0:50 ` Marek Vasut
2012-01-04  2:49   ` Mike Dunn
2012-01-04 21:30     ` Marek Vasut
2012-01-09 21:08 ` Artem Bityutskiy
2012-01-10 17:47   ` Robert Jarzmik
2012-01-10  8:25 ` Artem Bityutskiy
2012-01-12  3:41   ` Mike Dunn
2012-01-15 11:06     ` Robert Jarzmik
2012-01-16 19:13       ` Mike Dunn [this message]
2012-01-18 16:43         ` Artem Bityutskiy
2012-01-27 14:17 ` Artem Bityutskiy
2012-01-30  6:38   ` Mike Dunn
2012-01-30 13:28     ` Artem Bityutskiy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F1476F2.7040800@newsguy.com \
    --to=mikedunn@newsguy.com \
    --cc=dedekind1@gmail.com \
    --cc=linux-mtd@lists.infradead.org \
    --cc=robert.jarzmik@free.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.