From: Robert Jarzmik <robert.jarzmik@free.fr>
To: Mike Dunn <mikedunn@newsguy.com>
Cc: linux-mtd@lists.infradead.org, dedekind1@gmail.com
Subject: Re: [PATCH v4] MTD: nand: add support for diskonchip G4 nand flash device
Date: Sun, 15 Jan 2012 12:06:44 +0100 [thread overview]
Message-ID: <87y5t9xm0r.fsf@free.fr> (raw)
In-Reply-To: <4F0E567F.8020405@newsguy.com> (Mike Dunn's message of "Wed, 11 Jan 2012 19:41:51 -0800")
Mike Dunn <mikedunn@newsguy.com> writes:
> On 01/10/2012 12:25 AM, Artem Bityutskiy wrote:
>>
>> Would be nice if DoC guys could also fix huge amount of GCC warnings -
>> there are DoC I/O macro definitions which produce a warning every time
>> they are used - very annoying noise. I guess those macros can be turned
>> into static inline functions? Would someone take the initiative?
>
>
> Yeah, this thought crossed my mind every time I recompiled while working on the
> aborted api change patches. Gives DoC a bad name. I'll get to it shortly.
>
> Ping Robert. Care to take a look at the G4 driver?
I looked through. It looks good to me.
I have one warning remaining (on top of Linus tree):
drivers/mtd/nand/docg4.c: In function '__check_ignore_badblocks':
drivers/mtd/nand/docg4.c:52: warning: return from incompatible pointer type
My feeling is that the driver is good to be sent upstream, with my:
Reviewed-by: Robert Jarzmik <robert.jarzmik@free.fr>
If anything comes up, it can be fixed later, and I think we should go forward.
Cheers.
--
Robert
next prev parent reply other threads:[~2012-01-15 11:06 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-04 0:05 [PATCH v4] MTD: nand: add support for diskonchip G4 nand flash device Mike Dunn
2012-01-04 0:50 ` Marek Vasut
2012-01-04 2:49 ` Mike Dunn
2012-01-04 21:30 ` Marek Vasut
2012-01-09 21:08 ` Artem Bityutskiy
2012-01-10 17:47 ` Robert Jarzmik
2012-01-10 8:25 ` Artem Bityutskiy
2012-01-12 3:41 ` Mike Dunn
2012-01-15 11:06 ` Robert Jarzmik [this message]
2012-01-16 19:13 ` Mike Dunn
2012-01-18 16:43 ` Artem Bityutskiy
2012-01-27 14:17 ` Artem Bityutskiy
2012-01-30 6:38 ` Mike Dunn
2012-01-30 13:28 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y5t9xm0r.fsf@free.fr \
--to=robert.jarzmik@free.fr \
--cc=dedekind1@gmail.com \
--cc=linux-mtd@lists.infradead.org \
--cc=mikedunn@newsguy.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.