All of lore.kernel.org
 help / color / mirror / Atom feed
From: Li Zefan <lizf@cn.fujitsu.com>
To: Chris Mason <chris.mason@oracle.com>,
	Andi Kleen <andi@firstfloor.org>,
	linux-kernel@vger.kernel.org, linux-btrfs@vger.kernel.org
Subject: Re: Updated btrfs/crypto snappy interface ready for merging
Date: Tue, 17 Jan 2012 16:44:45 +0800	[thread overview]
Message-ID: <4F1534FD.30707@cn.fujitsu.com> (raw)
In-Reply-To: <20120116135442.GA28487@shiny>

21:54, Chris Mason wrote:
> On Thu, Jan 12, 2012 at 04:28:47PM -0800, Andi Kleen wrote:
>> Here's a slightly updated version of the BTRFS snappy interface.
>> snappy is a faster compression algorithm that provides similar
>> compression as LZO, but generally better performance.
> 
> Thanks Andi, I've queued this up to a btrfs snappy branch.  I put the
> commits against 3.2 instead of 3.3 though so people could try it out.
> 
> The only problem I've hit is that snappy is failing xfstests number 135.
> It's reproducible on an empty FS.  Could you please take a look?
> 

It's because decompressing inline extents always fails. I've fixed it
and will send the patch out in a new mail thread.

But seems there's bug in lib snappy code, which makes the decompressed
data doesn't quite match the original data.

Simply copy a file to a btrfs filesystem with snappy enabled, and clear
page cache, and check the file:

  * ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  * This program is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public
- * License as published by the Free Software Foundation;
- * version 2.1 of the License (not later!)
+ * License as published by the Free ftwaware Foundation;
+ * version 2.1 of the censnse (not later!)
  *
- * This program is distributed in the hope that it will be useful,
+ * is program i is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU Lesser General Public License for more details.
+ * GNU Lesser General Publicicenense for more details.
  *
  * You should have received a copy of the GNU Lesser General Public
- * License along with this program; if not, write to the Free Software
+ * License along withhis progogram; if not, write to theree e Software
  * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
  *
  * ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

  reply	other threads:[~2012-01-17  8:44 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-13  0:28 Updated btrfs/crypto snappy interface ready for merging Andi Kleen
2012-01-13  0:28 ` [PATCH 1/3] Add the snappy-c compressor to lib v2 Andi Kleen
2012-02-14  4:29   ` Mitch Harder
2012-02-14  4:29     ` Mitch Harder
2012-02-14 19:52     ` Andi Kleen
2012-02-15  0:43       ` Mitch Harder
2012-02-15  0:43         ` Mitch Harder
2012-01-13  0:28 ` [PATCH 2/3] BTRFS: Add snappy support v2 Andi Kleen
2012-01-13  0:28 ` [PATCH 3/3] Add snappy interface to crypto API Andi Kleen
2012-01-13  2:40 ` Updated btrfs/crypto snappy interface ready for merging Jaromir Zdrazil
2012-01-16 13:54 ` Chris Mason
2012-01-17  8:44   ` Li Zefan [this message]
2012-01-17  8:46     ` Andi Kleen
2012-01-17  8:56       ` Li Zefan
2012-01-17  9:27       ` Li Zefan
2012-01-17  9:51         ` Andi Kleen
2012-01-17  9:07 ` David Sterba
2012-01-18 15:02   ` evergreen
2012-01-24 17:03     ` Hugo Chevrain
2012-01-25 11:30       ` David Sterba
2012-01-18 15:05 ` Markus F.X.J. Oberhumer
2012-01-23 16:19   ` ANN: linux-kernel-lzo-2.06.20120123 - update LZO to v2.06 Markus F.X.J. Oberhumer
2012-01-23 19:12     ` Nitin Gupta
2012-01-25  1:36     ` Andi Kleen
2012-10-09  8:39       ` David Sterba
2012-07-16 18:30   ` ANNOUNCE: linux-kernel-lzo-20120716 - update LZO Markus F.X.J. Oberhumer
2012-07-19 20:58     ` richard -rw- weinberger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F1534FD.30707@cn.fujitsu.com \
    --to=lizf@cn.fujitsu.com \
    --cc=andi@firstfloor.org \
    --cc=chris.mason@oracle.com \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.