From: Andi Kleen <ak@linux.intel.com>
To: Mitch Harder <mitch.harder@sabayonlinux.org>
Cc: Andi Kleen <andi@firstfloor.org>,
chris.mason@oracle.com, linux-kernel@vger.kernel.org,
linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 1/3] Add the snappy-c compressor to lib v2
Date: Tue, 14 Feb 2012 11:52:06 -0800 [thread overview]
Message-ID: <4F3ABB66.1040202@linux.intel.com> (raw)
In-Reply-To: <CAKcLGm8u9oKEBjFW3VpLZDUd=56mRRrr-_zjf-M7Hf5NpTTM8Q@mail.gmail.com>
> (BTW: If you're ever reworking this patch set, I'd like to make an ad
> hoc request for slightly different names for fs/btrfs/snappy.c and
> lib/snappy.c)
Why?
> When building a x86 kernel, I get the following errors:
> CC [M] lib/snappy.o
> lib/snappy.c: In function 'snappy_init_env':
> lib/snappy.c:1268:2: error: implicit declaration of function 'vmalloc'
> CC [M] fs/btrfs/free-space-cache.o
> lib/snappy.c:1268:18: warning: assignment makes pointer from integer
> without a cast
> lib/snappy.c: In function 'snappy_free_env':
> lib/snappy.c:1293:2: error: implicit declaration of function 'vfree'
> make[1]: *** [lib/snappy.o] Error 1
> make: *** [lib] Error 2
>
> The error clears with this patch:
Added thanks.
-Andi
next prev parent reply other threads:[~2012-02-14 19:52 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-13 0:28 Updated btrfs/crypto snappy interface ready for merging Andi Kleen
2012-01-13 0:28 ` [PATCH 1/3] Add the snappy-c compressor to lib v2 Andi Kleen
2012-02-14 4:29 ` Mitch Harder
2012-02-14 4:29 ` Mitch Harder
2012-02-14 19:52 ` Andi Kleen [this message]
2012-02-15 0:43 ` Mitch Harder
2012-02-15 0:43 ` Mitch Harder
2012-01-13 0:28 ` [PATCH 2/3] BTRFS: Add snappy support v2 Andi Kleen
2012-01-13 0:28 ` [PATCH 3/3] Add snappy interface to crypto API Andi Kleen
2012-01-13 2:40 ` Updated btrfs/crypto snappy interface ready for merging Jaromir Zdrazil
2012-01-16 13:54 ` Chris Mason
2012-01-17 8:44 ` Li Zefan
2012-01-17 8:46 ` Andi Kleen
2012-01-17 8:56 ` Li Zefan
2012-01-17 9:27 ` Li Zefan
2012-01-17 9:51 ` Andi Kleen
2012-01-17 9:07 ` David Sterba
2012-01-18 15:02 ` evergreen
2012-01-24 17:03 ` Hugo Chevrain
2012-01-25 11:30 ` David Sterba
2012-01-18 15:05 ` Markus F.X.J. Oberhumer
2012-01-23 16:19 ` ANN: linux-kernel-lzo-2.06.20120123 - update LZO to v2.06 Markus F.X.J. Oberhumer
2012-01-23 19:12 ` Nitin Gupta
2012-01-25 1:36 ` Andi Kleen
2012-10-09 8:39 ` David Sterba
2012-07-16 18:30 ` ANNOUNCE: linux-kernel-lzo-20120716 - update LZO Markus F.X.J. Oberhumer
2012-07-19 20:58 ` richard -rw- weinberger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F3ABB66.1040202@linux.intel.com \
--to=ak@linux.intel.com \
--cc=andi@firstfloor.org \
--cc=chris.mason@oracle.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mitch.harder@sabayonlinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.