Re: [Qemu-devel] [RFC PATCH 5/9] qtest: do not use TCG CPU threads

["Andreas Färber" <afaerber@suse.de>]

Am 18.01.2012 11:33, schrieb Paolo Bonzini:
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>  cpu-exec.c |    4 ---
>  cpus.c     |   62 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++--
>  2 files changed, 59 insertions(+), 7 deletions(-)

> diff --git a/cpus.c b/cpus.c
> index 2dae549..c4ca26a 100644
> --- a/cpus.c
> +++ b/cpus.c

> -    if (kvm_enabled() && !env->thread_kicked) {
> +    if (!tcg_enabled() && !env->thread_kicked) {

> -    if (kvm_enabled()) {
> +    if (!tcg_enabled()) {

>      if (kvm_enabled()) {
>          qemu_kvm_start_vcpu(env);
> -    } else {
> +    } else if (tcg_enabled()) {
>          qemu_tcg_init_vcpu(env);
> +    } else {
> +        qemu_dummy_start_vcpu(env);
>      }

Did you keep Xen in mind when changing the logic?

Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg