All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sha <handai.szj@gmail.com>
To: Michal Hocko <mhocko@suse.cz>
Cc: Johannes Weiner <hannes@cmpxchg.org>,
	Ying Han <yinghan@google.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
	Balbir Singh <bsingharora@gmail.com>,
	cgroups@vger.kernel.org, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org
Subject: Re: [patch 2/2] mm: memcg: hierarchical soft limit reclaim
Date: Thu, 19 Jan 2012 14:38:16 +0800	[thread overview]
Message-ID: <4F17BA58.2090403@gmail.com> (raw)
In-Reply-To: <20120118152708.GG31112@tiehlicka.suse.cz>

On 01/18/2012 11:27 PM, Michal Hocko wrote:
> On Wed 18-01-12 19:25:27, Sha wrote:
> [...]
>> Er... I'm even more confused: mem_cgroup_soft_limit_reclaim indeed
>> choses the biggest soft-limit excessor first, but in the succeeding reclaim
>> mem_cgroup_hierarchical_reclaim just selects a child cgroup  by css_id
> mem_cgroup_soft_limit_reclaim picks up the hierarchy root (most
> excessing one) and mem_cgroup_hierarchical_reclaim reclaims from that
> subtree). It doesn't care who exceeds the soft limit under that
> hierarchy it just tries to push the root under its limit as much as it
> can. This is what Johannes tried to explain in the other email in the
> thred.
yeah, I finally twig what  he meant... I'm not quite familiar with this 
part.
Thanks a lot for the explanation. :-)

Sha
>> which has nothing to do with soft limit (see mem_cgroup_select_victim).
>> IMHO, it's not a genuine hierarchical reclaim.
> It is hierarchical because it iterates over hierarchy it is not and
> never was recursively soft-hierarchical...
>

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: Sha <handai.szj@gmail.com>
To: Michal Hocko <mhocko@suse.cz>
Cc: Johannes Weiner <hannes@cmpxchg.org>,
	Ying Han <yinghan@google.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
	Balbir Singh <bsingharora@gmail.com>,
	cgroups@vger.kernel.org, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org
Subject: Re: [patch 2/2] mm: memcg: hierarchical soft limit reclaim
Date: Thu, 19 Jan 2012 14:38:16 +0800	[thread overview]
Message-ID: <4F17BA58.2090403@gmail.com> (raw)
In-Reply-To: <20120118152708.GG31112@tiehlicka.suse.cz>

On 01/18/2012 11:27 PM, Michal Hocko wrote:
> On Wed 18-01-12 19:25:27, Sha wrote:
> [...]
>> Er... I'm even more confused: mem_cgroup_soft_limit_reclaim indeed
>> choses the biggest soft-limit excessor first, but in the succeeding reclaim
>> mem_cgroup_hierarchical_reclaim just selects a child cgroup  by css_id
> mem_cgroup_soft_limit_reclaim picks up the hierarchy root (most
> excessing one) and mem_cgroup_hierarchical_reclaim reclaims from that
> subtree). It doesn't care who exceeds the soft limit under that
> hierarchy it just tries to push the root under its limit as much as it
> can. This is what Johannes tried to explain in the other email in the
> thred.
yeah, I finally twig what  he meant... I'm not quite familiar with this 
part.
Thanks a lot for the explanation. :-)

Sha
>> which has nothing to do with soft limit (see mem_cgroup_select_victim).
>> IMHO, it's not a genuine hierarchical reclaim.
> It is hierarchical because it iterates over hierarchy it is not and
> never was recursively soft-hierarchical...
>


  reply	other threads:[~2012-01-19  6:38 UTC|newest]

Thread overview: 76+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-10 15:02 [patch 0/2] mm: memcg reclaim integration followups Johannes Weiner
2012-01-10 15:02 ` Johannes Weiner
2012-01-10 15:02 ` [patch 1/2] mm: memcg: per-memcg reclaim statistics Johannes Weiner
2012-01-10 15:02   ` Johannes Weiner
     [not found]   ` <1326207772-16762-2-git-send-email-hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org>
2012-01-10 23:54     ` Ying Han
2012-01-10 23:54       ` Ying Han
2012-01-10 23:54       ` Ying Han
     [not found]       ` <CALWz4izbTw4+7zbfiED9Lx=6RwiqxE11g5-fNRHTh=mcP=vQ2Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-01-11  0:30         ` Johannes Weiner
2012-01-11  0:30           ` Johannes Weiner
2012-01-11  0:30           ` Johannes Weiner
2012-01-11 22:33           ` Ying Han
2012-01-11 22:33             ` Ying Han
     [not found]             ` <CALWz4iy4hw9jQ++w4oiZG_hih-x9iieuEmnRBfxYKriAKSoOgw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-01-12  9:17               ` Johannes Weiner
2012-01-12  9:17                 ` Johannes Weiner
2012-01-12  9:17                 ` Johannes Weiner
2012-01-10 15:02 ` [patch 2/2] mm: memcg: hierarchical soft limit reclaim Johannes Weiner
2012-01-10 15:02   ` Johannes Weiner
2012-01-11 21:42   ` Ying Han
2012-01-11 21:42     ` Ying Han
     [not found]     ` <CALWz4izwNBN_qcSsqg-qYw-Esc9vBL3=4cv3Wsg1jf6001_fWQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-01-12  8:59       ` Johannes Weiner
2012-01-12  8:59         ` Johannes Weiner
2012-01-12  8:59         ` Johannes Weiner
     [not found]         ` <20120112085904.GG24386-druUgvl0LCNAfugRpC6u6w@public.gmane.org>
2012-01-13 21:31           ` Ying Han
2012-01-13 21:31             ` Ying Han
2012-01-13 21:31             ` Ying Han
     [not found]             ` <CALWz4iz3sQX+pCr19rE3_SwV+pRFhDJ7Lq-uJuYBq6u3mRU3AQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-01-13 22:44               ` Johannes Weiner
2012-01-13 22:44                 ` Johannes Weiner
2012-01-13 22:44                 ` Johannes Weiner
     [not found]                 ` <20120113224424.GC1653-druUgvl0LCNAfugRpC6u6w@public.gmane.org>
2012-01-17 14:22                   ` Sha
2012-01-17 14:22                     ` Sha
2012-01-17 14:22                     ` Sha
     [not found]                     ` <4F158418.2090509-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2012-01-17 14:53                       ` Johannes Weiner
2012-01-17 14:53                         ` Johannes Weiner
2012-01-17 14:53                         ` Johannes Weiner
     [not found]                         ` <20120117145348.GA3144-druUgvl0LCNAfugRpC6u6w@public.gmane.org>
2012-01-17 20:25                           ` Ying Han
2012-01-17 20:25                             ` Ying Han
2012-01-17 20:25                             ` Ying Han
     [not found]                             ` <CALWz4iwYpkP6Dfz+3NFXQK9ToaKdm8WCsbBmHRLVwRjVp0wjOQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-01-17 21:56                               ` Johannes Weiner
2012-01-17 21:56                                 ` Johannes Weiner
2012-01-17 21:56                                 ` Johannes Weiner
2012-01-17 23:39                                 ` Ying Han
2012-01-17 23:39                                   ` Ying Han
2012-01-18  7:17                         ` Sha
     [not found]                           ` <CAFj3OHWY2Biw54gaGeH5fkxzgOhxn7NAibeYT_Jmga-_ypNSRg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-01-18  9:25                             ` Johannes Weiner
2012-01-18  9:25                               ` Johannes Weiner
2012-01-18  9:25                               ` Johannes Weiner
2012-01-18 11:25                               ` Sha
2012-01-18 11:25                                 ` Sha
2012-01-18 15:27                                 ` Michal Hocko
2012-01-18 15:27                                   ` Michal Hocko
2012-01-19  6:38                                   ` Sha [this message]
2012-01-19  6:38                                     ` Sha
     [not found]   ` <1326207772-16762-3-git-send-email-hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org>
2012-01-12  1:54     ` KAMEZAWA Hiroyuki
2012-01-12  1:54       ` KAMEZAWA Hiroyuki
2012-01-12  1:54       ` KAMEZAWA Hiroyuki
2012-01-13 12:16       ` Johannes Weiner
2012-01-13 12:16         ` Johannes Weiner
     [not found]         ` <20120113121645.GA1653-druUgvl0LCNAfugRpC6u6w@public.gmane.org>
2012-01-18  5:26           ` KAMEZAWA Hiroyuki
2012-01-18  5:26             ` KAMEZAWA Hiroyuki
2012-01-18  5:26             ` KAMEZAWA Hiroyuki
2012-01-13 12:04     ` Michal Hocko
2012-01-13 12:04       ` Michal Hocko
2012-01-13 12:04       ` Michal Hocko
2012-01-13 15:50       ` Johannes Weiner
2012-01-13 15:50         ` Johannes Weiner
     [not found]         ` <20120113155001.GB1653-druUgvl0LCNAfugRpC6u6w@public.gmane.org>
2012-01-13 16:34           ` Michal Hocko
2012-01-13 16:34             ` Michal Hocko
2012-01-13 16:34             ` Michal Hocko
     [not found]             ` <20120113163423.GG17060-VqjxzfR4DlwKmadIfiO5sKVXKuFTiq87@public.gmane.org>
2012-01-13 21:45               ` Ying Han
2012-01-13 21:45                 ` Ying Han
2012-01-13 21:45                 ` Ying Han
2012-01-18  9:45                 ` Johannes Weiner
2012-01-18  9:45                   ` Johannes Weiner
2012-01-18  9:45                   ` Johannes Weiner
2012-01-18 20:38                   ` Ying Han
2012-01-18 20:38                     ` Ying Han

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F17BA58.2090403@gmail.com \
    --to=handai.szj@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=bsingharora@gmail.com \
    --cc=cgroups@vger.kernel.org \
    --cc=hannes@cmpxchg.org \
    --cc=kamezawa.hiroyu@jp.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@suse.cz \
    --cc=yinghan@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.