Re: [PATCH v8 18/18] kvm: Activate in-kernel irqchip support

[Jan Kiszka <jan.kiszka@web.de>]

[-- Attachment #1: Type: text/plain, Size: 1304 bytes --]

On 2012-01-19 19:08, Marcelo Tosatti wrote:
> On Thu, Jan 19, 2012 at 12:25:10PM +0100, Jan Kiszka wrote:
>> Make the basic in-kernel irqchip support selectable via
>> -machine ...,kernel_irqchip=on. Leave it off by default until it can
>> fully replace user space models.
>>
>> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
>> ---
>>  qemu-config.c   |    4 ++++
>>  qemu-options.hx |    5 ++++-
>>  2 files changed, 8 insertions(+), 1 deletions(-)
>>
>> diff --git a/qemu-config.c b/qemu-config.c
>> index ecc88e8..b030205 100644
>> --- a/qemu-config.c
>> +++ b/qemu-config.c
>> @@ -531,6 +531,10 @@ static QemuOptsList qemu_machine_opts = {
>>              .name = "accel",
>>              .type = QEMU_OPT_STRING,
>>              .help = "accelerator list",
>> +        }, {
>> +            .name = "kernel_irqchip",
>> +            .type = QEMU_OPT_BOOL,
>> +            .help = "use KVM in-kernel irqchip",
>>          },
>>          { /* End of list */ }
>>      },
> 
> 
> Pulled (and pushed),

Thanks. Will refresh my back-merge patch for qemu-kvm now.

> but you forgot to actually hook this option to kvm_irqchip_in_kernel?
> 

Nope, see kvm_irqchip_create, patch 13. You can also check by browsing
the qtree (different device model names).

Jan


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 262 bytes --]