From: Paolo Bonzini <pbonzini@redhat.com>
To: Jan Kiszka <jan.kiszka@siemens.com>,
qemu-devel <qemu-devel@nongnu.org>,
qemu-trivial <qemu-trivial@nongnu.org>
Subject: Re: [Qemu-trivial] [PATCH] rename get_clock_realtime
Date: Fri, 20 Jan 2012 12:39:34 +0100 [thread overview]
Message-ID: <4F195276.9000308@redhat.com> (raw)
In-Reply-To: <4F195003.7050500@siemens.com>
On 01/20/2012 12:29 PM, Jan Kiszka wrote:
>> > Yeah, however, realtime is quite confusing because CLOCK_MONOTONIC is
>> > part of the "real-time clock API". The code is much clearer than the
>> > comment, I'll remove it completely. v2 on the way.
> There is CLOCK_MONOTONIC and CLOCK_REALTIME, and this function uses the
> latter.
Actually it uses gettimeofday, but I see what you mean.
But QEMU_CLOCK_REALTIME and rt_clock refer to CLOCK_MONOTONIC and are
_not_ read by get_clock_realtime. This actually is what prompted me to
rename get_clock_realtime (see commit message).
Paolo
WARNING: multiple messages have this Message-ID (diff)
From: Paolo Bonzini <pbonzini@redhat.com>
To: Jan Kiszka <jan.kiszka@siemens.com>,
qemu-devel <qemu-devel@nongnu.org>,
qemu-trivial <qemu-trivial@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] rename get_clock_realtime
Date: Fri, 20 Jan 2012 12:39:34 +0100 [thread overview]
Message-ID: <4F195276.9000308@redhat.com> (raw)
In-Reply-To: <4F195003.7050500@siemens.com>
On 01/20/2012 12:29 PM, Jan Kiszka wrote:
>> > Yeah, however, realtime is quite confusing because CLOCK_MONOTONIC is
>> > part of the "real-time clock API". The code is much clearer than the
>> > comment, I'll remove it completely. v2 on the way.
> There is CLOCK_MONOTONIC and CLOCK_REALTIME, and this function uses the
> latter.
Actually it uses gettimeofday, but I see what you mean.
But QEMU_CLOCK_REALTIME and rt_clock refer to CLOCK_MONOTONIC and are
_not_ read by get_clock_realtime. This actually is what prompted me to
rename get_clock_realtime (see commit message).
Paolo
next prev parent reply other threads:[~2012-01-20 11:39 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-20 11:05 [Qemu-trivial] [PATCH] rename get_clock_realtime Paolo Bonzini
2012-01-20 11:05 ` [Qemu-devel] " Paolo Bonzini
2012-01-20 11:17 ` [Qemu-trivial] " Jan Kiszka
2012-01-20 11:17 ` [Qemu-devel] " Jan Kiszka
2012-01-20 11:26 ` [Qemu-trivial] " Paolo Bonzini
2012-01-20 11:26 ` [Qemu-devel] " Paolo Bonzini
2012-01-20 11:28 ` [Qemu-devel] [PATCH v2] " Paolo Bonzini
2012-01-20 11:29 ` [Qemu-trivial] [PATCH] " Jan Kiszka
2012-01-20 11:29 ` [Qemu-devel] " Jan Kiszka
2012-01-20 11:39 ` Paolo Bonzini [this message]
2012-01-20 11:39 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F195276.9000308@redhat.com \
--to=pbonzini@redhat.com \
--cc=jan.kiszka@siemens.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.