From: Jan Kiszka <jan.kiszka@siemens.com>
To: Christoffer Dall <c.dall@virtualopensystems.com>
Cc: kvm@vger.kernel.org, Marc.Zyngier@arm.com, mtosatti@redhat.com,
agraf@suse.de, kvm-ppc@vger.kernel.org, avi@redhat.com,
android-virt@lists.cs.columbia.edu, tech@virtualopensystems.com
Subject: Re: [PATCH] KVM: Factor out kvm_vcpu_kick to arch-generic code
Date: Fri, 20 Jan 2012 16:43:28 +0000 [thread overview]
Message-ID: <4F1999B0.6020208@siemens.com> (raw)
In-Reply-To: <20120120032241.24615.65895.stgit@localhost>
On 2012-01-20 04:22, Christoffer Dall wrote:
> diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c
> index d9cfb78..cd30b68 100644
> --- a/virt/kvm/kvm_main.c
> +++ b/virt/kvm/kvm_main.c
> @@ -153,6 +153,7 @@ void vcpu_load(struct kvm_vcpu *vcpu)
> cpu = get_cpu();
> preempt_notifier_register(&vcpu->preempt_notifier);
> kvm_arch_vcpu_load(vcpu, cpu);
> + vcpu->cpu = cpu;
That means setting it in the various kvm_arch_vcpu_load handlers becomes
redundant and should be cleaned up.
Jan
--
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux
WARNING: multiple messages have this Message-ID (diff)
From: Jan Kiszka <jan.kiszka@siemens.com>
To: Christoffer Dall <c.dall@virtualopensystems.com>
Cc: kvm@vger.kernel.org, Marc.Zyngier@arm.com, mtosatti@redhat.com,
agraf@suse.de, kvm-ppc@vger.kernel.org, avi@redhat.com,
android-virt@lists.cs.columbia.edu, tech@virtualopensystems.com
Subject: Re: [PATCH] KVM: Factor out kvm_vcpu_kick to arch-generic code
Date: Fri, 20 Jan 2012 17:43:28 +0100 [thread overview]
Message-ID: <4F1999B0.6020208@siemens.com> (raw)
In-Reply-To: <20120120032241.24615.65895.stgit@localhost>
On 2012-01-20 04:22, Christoffer Dall wrote:
> diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c
> index d9cfb78..cd30b68 100644
> --- a/virt/kvm/kvm_main.c
> +++ b/virt/kvm/kvm_main.c
> @@ -153,6 +153,7 @@ void vcpu_load(struct kvm_vcpu *vcpu)
> cpu = get_cpu();
> preempt_notifier_register(&vcpu->preempt_notifier);
> kvm_arch_vcpu_load(vcpu, cpu);
> + vcpu->cpu = cpu;
That means setting it in the various kvm_arch_vcpu_load handlers becomes
redundant and should be cleaned up.
Jan
--
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux
next prev parent reply other threads:[~2012-01-20 16:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-20 3:22 [PATCH] KVM: Factor out kvm_vcpu_kick to arch-generic code Christoffer Dall
2012-01-20 3:22 ` Christoffer Dall
2012-01-20 16:43 ` Jan Kiszka [this message]
2012-01-20 16:43 ` Jan Kiszka
2012-01-23 16:31 ` Marcelo Tosatti
2012-01-23 16:31 ` Marcelo Tosatti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F1999B0.6020208@siemens.com \
--to=jan.kiszka@siemens.com \
--cc=Marc.Zyngier@arm.com \
--cc=agraf@suse.de \
--cc=android-virt@lists.cs.columbia.edu \
--cc=avi@redhat.com \
--cc=c.dall@virtualopensystems.com \
--cc=kvm-ppc@vger.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=tech@virtualopensystems.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.