Re: [PATCH] x86/vMSI: miscellaneous fixes

[Andrew Cooper <andrew.cooper3@citrix.com>]

On 20/01/12 16:44, Jan Beulich wrote:
>>>> On 20.01.12 at 17:39, Andrew Cooper <andrew.cooper3@citrix.com> wrote:
>> On 20/01/12 16:33, Jan Beulich wrote:
>>> @@ -291,9 +285,22 @@ static int msixtbl_write(struct vcpu *v,
>>>      if ( !virt )
>>>          goto out;
>>>  
>>> +    /* Do not allow the mask bit to be changed. */
>>> +#if 0 /* XXX
>> You appear to still have some debugging in this patch.
> No - that's why the comment is there. I wanted to keep the unused
> code to make clear what ought to be taking place here.
>
> Jan

Ah - that makes a little more sense.  That was going to be my next query
for clarification.

I have some hardware at my disposal which can do SRIOV and PCI
passthrough with MSI-X capable network cards.

Any specific things you want testing, other than just a basic
passthrough and verify the cards are working?

~Andrew

>>> +       * As the mask bit is the only defined bit in the word, and as the
>>> +       * host MSI-X code doesn't preserve the other bits anyway, doing
>>> +       * this is pointless. So for now just discard the write (also
>>> +       * saving us from having to determine the matching irq_desc).
>>> +       */
>
>

-- 
Andrew Cooper - Dom0 Kernel Engineer, Citrix XenServer
T: +44 (0)1223 225 900, http://www.citrix.com