From: Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
To: Simon Glass <sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
Cc: U-Boot Mailing List
<u-boot-0aAXYlwwYIKGBzrmiIFOJg@public.gmane.org>,
Devicetree Discuss
<devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org>,
Tom Warren <TWarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
Jerry Van Baren
<vanbaren-He//nVnquyzQT0dZR+AlfA@public.gmane.org>
Subject: Re: [PATCH v3 5/9] tegra: fdt: Add keyboard controller definition
Date: Fri, 20 Jan 2012 16:30:44 -0700 [thread overview]
Message-ID: <4F19F924.5020508@nvidia.com> (raw)
In-Reply-To: <1326780682-10260-6-git-send-email-sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
On 01/16/2012 11:11 PM, Simon Glass wrote:
> From: Anton Staff <robotboy-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
>
> The Tegra keyboard controller provides a simple interface to a matrix
> keyboard.
> diff --git a/arch/arm/dts/tegra20.dtsi b/arch/arm/dts/tegra20.dtsi
> + kbc@7000e200 {
> + compatible = "nvidia,tegra20-kbc";
> + reg = <0x7000e200 0x0078>;
> + };
The KBC has interrupts to, which should be added to the .dtsi even if
you don't use them.
I think you want:
interrupts = <0 85 0x04>;
--
nvpublic
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Warren <swarren@nvidia.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3 5/9] tegra: fdt: Add keyboard controller definition
Date: Fri, 20 Jan 2012 16:30:44 -0700 [thread overview]
Message-ID: <4F19F924.5020508@nvidia.com> (raw)
In-Reply-To: <1326780682-10260-6-git-send-email-sjg@chromium.org>
On 01/16/2012 11:11 PM, Simon Glass wrote:
> From: Anton Staff <robotboy@chromium.org>
>
> The Tegra keyboard controller provides a simple interface to a matrix
> keyboard.
> diff --git a/arch/arm/dts/tegra20.dtsi b/arch/arm/dts/tegra20.dtsi
> + kbc at 7000e200 {
> + compatible = "nvidia,tegra20-kbc";
> + reg = <0x7000e200 0x0078>;
> + };
The KBC has interrupts to, which should be added to the .dtsi even if
you don't use them.
I think you want:
interrupts = <0 85 0x04>;
--
nvpublic
next prev parent reply other threads:[~2012-01-20 23:30 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-17 6:11 [U-Boot] [PATCH v3 0/9] tegra: Enable keyboard with matrix keyboard driver Simon Glass
2012-01-17 6:11 ` [U-Boot] [PATCH v3 2/9] input: Add linux/input.h for key code support Simon Glass
2012-01-17 6:11 ` [U-Boot] [PATCH v3 3/9] input: Add generic keyboard input handler Simon Glass
2012-01-17 6:11 ` [U-Boot] [PATCH v3 4/9] tegra: Add keyboard support to funcmux Simon Glass
2012-01-20 23:23 ` Stephen Warren
[not found] ` <1326780682-10260-1-git-send-email-sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2012-01-17 6:11 ` [PATCH v3 1/9] fdt: Add fdtdec functions to read byte array Simon Glass
2012-01-17 6:11 ` [U-Boot] " Simon Glass
2012-01-17 6:30 ` Mike Frysinger
2012-01-17 6:30 ` [U-Boot] " Mike Frysinger
[not found] ` <201201170130.48257.vapier-aBrp7R+bbdUdnm+yROfE0A@public.gmane.org>
2012-01-17 7:11 ` Simon Glass
2012-01-17 7:11 ` [U-Boot] " Simon Glass
2012-01-17 15:52 ` Mike Frysinger
2012-01-17 15:52 ` [U-Boot] " Mike Frysinger
2012-01-17 6:11 ` [PATCH v3 5/9] tegra: fdt: Add keyboard controller definition Simon Glass
2012-01-17 6:11 ` [U-Boot] " Simon Glass
[not found] ` <1326780682-10260-6-git-send-email-sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2012-01-20 23:30 ` Stephen Warren [this message]
2012-01-20 23:30 ` Stephen Warren
2012-01-17 6:11 ` [PATCH v3 6/9] tegra: fdt: Add keyboard definitions for Seaboard Simon Glass
2012-01-17 6:11 ` [U-Boot] " Simon Glass
2012-01-17 6:11 ` [U-Boot] [PATCH v3 7/9] tegra: Add tegra keyboard driver Simon Glass
2012-01-20 23:50 ` Stephen Warren
2012-01-17 6:11 ` [U-Boot] [PATCH v3 8/9] tegra: Switch on console mux and use environment for console Simon Glass
2012-01-17 6:11 ` [U-Boot] [PATCH v3 9/9] tegra: Enable keyboard for Seaboard Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F19F924.5020508@nvidia.com \
--to=swarren-ddmlm1+adcrqt0dzr+alfa@public.gmane.org \
--cc=TWarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
--cc=sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
--cc=u-boot-0aAXYlwwYIKGBzrmiIFOJg@public.gmane.org \
--cc=vanbaren-He//nVnquyzQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.