Re: [PATCH V1] mfd: tps65910: Add wakeup support

[Laxman Dewangan <ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>]

Resending as text formatting was not proper. Sorry for inconvenience..

On Friday 20 January 2012 06:43 PM, Mark Brown wrote:
> On Fri, Jan 20, 2012 at 06:37:42PM +0530, Laxman Dewangan wrote:
>>> No, that's it - when you call those userspace will get control via sysfs
>>> for turning on and off the wakeup support.
>> So should I call them in driver by default without taking parameter
>> from platform data?
> That's the normal behaviour for drivers unless there's some specific
> reason for doing something different.  The choice may well depend on the
> application software running on the system rather than the kernel.
Going through the details of documentation under 
/sys/devices/.../power/wakeup files of power/device.txt, I think 
following should be the change if we want to control the wakeup control 
through user sapce:
During initialization of device, we need to tell that device is wakeup 
capable and hence we need to call the: device_wakeup_init() and 
device_set_wakeup_capable(dev, true).
Then it exposes the required sysfs to userspace to select the wakeup 
enable or not i.e. power/wakeup to be written as enabled or disabled.
Based on user selection, the function device_may_wakeup() will return 
true/false based on  power/wakeup enabled/disabled. So before entering 
into the suspend, we need to check this function and call 
enable_irq_wakeup() to have the wakeup enabled actually in the soc. In 
resume we need to call disable_irq_wake() again.

If this is correct approach then I can push the another patch.