All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: Stefan Weil <sw@weilnetz.de>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-trivial] [PATCH] block/vdi: Zero unused parts when allocating a new block (fix #919242)
Date: Mon, 23 Jan 2012 12:52:20 +0100	[thread overview]
Message-ID: <4F1D49F4.5090801@redhat.com> (raw)
In-Reply-To: <1327150464-29682-1-git-send-email-sw@weilnetz.de>

Am 21.01.2012 13:54, schrieb Stefan Weil:
> The new block was filled with zero when it was allocated by g_malloc0,
> but when it was reused later and only partially used, data from the
> previously allocated block were still present and written to the new
> block.
> 
> This caused the problems reported by bug #919242
> (https://bugs.launchpad.net/qemu/+bug/919242).
> 
> Now the unused parts of the new block which are before and after the data
> are always filled with zero, so it is no longer necessary to zero the whole
> block with g_malloc0.
> 
> I also updated the copyright comment.
> 
> Signed-off-by: Stefan Weil <sw@weilnetz.de>

Thanks, applied to the block branch (this is not trivial!)

Kevin


WARNING: multiple messages have this Message-ID (diff)
From: Kevin Wolf <kwolf@redhat.com>
To: Stefan Weil <sw@weilnetz.de>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] block/vdi: Zero unused parts when allocating a new block (fix #919242)
Date: Mon, 23 Jan 2012 12:52:20 +0100	[thread overview]
Message-ID: <4F1D49F4.5090801@redhat.com> (raw)
In-Reply-To: <1327150464-29682-1-git-send-email-sw@weilnetz.de>

Am 21.01.2012 13:54, schrieb Stefan Weil:
> The new block was filled with zero when it was allocated by g_malloc0,
> but when it was reused later and only partially used, data from the
> previously allocated block were still present and written to the new
> block.
> 
> This caused the problems reported by bug #919242
> (https://bugs.launchpad.net/qemu/+bug/919242).
> 
> Now the unused parts of the new block which are before and after the data
> are always filled with zero, so it is no longer necessary to zero the whole
> block with g_malloc0.
> 
> I also updated the copyright comment.
> 
> Signed-off-by: Stefan Weil <sw@weilnetz.de>

Thanks, applied to the block branch (this is not trivial!)

Kevin

  parent reply	other threads:[~2012-01-23 11:49 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-21 12:54 [Qemu-trivial] [PATCH] block/vdi: Zero unused parts when allocating a new block (fix #919242) Stefan Weil
2012-01-21 12:54 ` [Qemu-devel] " Stefan Weil
2012-01-21 17:31 ` Stefan Weil
2012-01-23 11:52 ` Kevin Wolf [this message]
2012-01-23 11:52   ` Kevin Wolf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F1D49F4.5090801@redhat.com \
    --to=kwolf@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    --cc=sw@weilnetz.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.