From: "H. Peter Anvin" <hpa@linux.intel.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Hitoshi Mitake <h.mitake@gmail.com>, Ingo Molnar <mingo@elte.hu>,
Matthew Wilcox <matthew.r.wilcox@intel.com>,
Roland Dreier <roland@purestorage.com>,
Andrew Morton <akpm@linux-foundation.org>,
James Bottomley <James.Bottomley@parallels.com>,
linux-kernel@vger.kernel.org, linux-nvme@infradead.org
Subject: Re: [PATCH] NVMe: Fix compilation on architecturs without readq/writeq
Date: Mon, 23 Jan 2012 15:04:27 -0800 [thread overview]
Message-ID: <4F1DE77B.50004@linux.intel.com> (raw)
In-Reply-To: <CA+55aFz=KcR5ji3TBHyfAYxFg8PCjXbdLOWf7aXULYHW4pp2kg@mail.gmail.com>
On 01/23/2012 08:57 AM, Linus Torvalds wrote:
> On Mon, Jan 23, 2012 at 8:05 AM, Hitoshi Mitake<h.mitake@gmail.com> wrote:
>>
>> I wrote the patch which adds the new file include/asm-generic/io-nonatomic.h.
>> io-nonatomic.h provides non-atomic version readq()/writeq().
>
> I do wonder if we should do "little-endian" and "big-endian" variations?
>
> Quoting Willy:
>
> "For this particular hardware, it's defined to work if you read the
> low order bits first"
>
> so I think we need make that explicit, and make two include files:
>
> include/asm-generic/io-64b-lo-hi.h
> include/asm-generic/io-64b-hi-lo.h
>
> or something like that. And thus indirectly document these kinds of
> requirements.
>
I would concur with this (and I have suggested exactly this in the past.)
-hpa
next prev parent reply other threads:[~2012-01-23 23:04 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-20 1:01 [PATCH] NVMe: Fix compilation on architecturs without readq/writeq Matthew Wilcox
2012-01-20 1:21 ` Linus Torvalds
2012-01-20 17:43 ` Wilcox, Matthew R
2012-01-21 8:28 ` Ingo Molnar
2012-01-21 15:54 ` Hitoshi Mitake
2012-01-21 16:58 ` Ingo Molnar
2012-01-23 16:05 ` Hitoshi Mitake
2012-01-23 16:57 ` Linus Torvalds
2012-01-23 23:04 ` H. Peter Anvin [this message]
2012-01-29 8:02 ` Hitoshi Mitake
2012-01-31 3:03 ` Linus Torvalds
2012-01-31 3:05 ` Linus Torvalds
2012-02-04 15:25 ` Hitoshi Mitake
2012-01-31 11:58 ` Alan Cox
2012-01-31 12:09 ` Ingo Molnar
2012-01-31 12:18 ` Alan Cox
2012-01-31 12:23 ` Ingo Molnar
2012-02-01 23:35 ` Linus Torvalds
2012-02-02 1:05 ` James Bottomley
2012-02-02 1:15 ` Linus Torvalds
2012-02-02 15:05 ` H. Peter Anvin
2012-02-04 15:39 ` Hitoshi Mitake
2012-02-05 6:53 ` Geert Uytterhoeven
2012-02-05 7:01 ` Hitoshi Mitake
2012-02-04 15:34 ` Hitoshi Mitake
2012-02-07 2:48 ` Hitoshi Mitake
2012-02-04 15:24 ` Hitoshi Mitake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F1DE77B.50004@linux.intel.com \
--to=hpa@linux.intel.com \
--cc=James.Bottomley@parallels.com \
--cc=akpm@linux-foundation.org \
--cc=h.mitake@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@infradead.org \
--cc=matthew.r.wilcox@intel.com \
--cc=mingo@elte.hu \
--cc=roland@purestorage.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.