From: Rob Herring <robherring2-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Russell King - ARM Linux
<linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org>,
Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Cc: "Grant Likely
(grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org)"
<grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>,
"linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"Thomas Gleixner (tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org)"
<tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>,
"linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org"
<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>
Subject: Re: How to represent active low ARM GIC interrupts, enabled by external inverter?
Date: Mon, 23 Jan 2012 17:12:34 -0600 [thread overview]
Message-ID: <4F1DE962.6030906@gmail.com> (raw)
In-Reply-To: <20120123223315.GB1068-l+eeeJia6m9vn6HldHNs0ANdhmdF6hFW@public.gmane.org>
On 01/23/2012 04:33 PM, Russell King - ARM Linux wrote:
> On Mon, Jan 23, 2012 at 01:18:50PM -0800, Stephen Warren wrote:
>> I'd like guidance on how to model one aspect of Tegra's interrupt
>> structure.
>>
>> Tegra has an interrupt input pin for use by a PMU chip.
>>
>> The PMC HW module within Tegra can optionally invert this signal, but
>> otherwise has no control over it; no interrupt status bits, no masking,
>> etc.
>>
>> The (potentially inverted) signal is then fed into the ARM GIC, which
>> supports level high or rising edge interrupts only.
Stephen, isn't this the same question you posted before except where the
inverter is is different?
http://lists.ozlabs.org/pipermail/devicetree-discuss/2011-December/009880.html
>
> When I originally added the IRQ trigger types to request_irq(), the
> original intention was for these to be specified by the requesting
> driver according to what the chip required, and there to be some kind
> of hook to deal with the inversion which happens on some boards.
>
> However, that was never implemented because there was a far better
> solution: pass this information to the driver via the device resource
> structures, which already have this information defined for PNP
> devices. The driver would then find the IRQ resource which would
> tell it both the number and the IRQ trigger flags to be used.
>
> Some drivers have done this, to cope with differing wiring on boards.
> I don't know if DT supports this though, but I'd suggest that it's
> a solution worth investigating.
>
As my suggestion was the same approach as Russell's.
Rob
WARNING: multiple messages have this Message-ID (diff)
From: robherring2@gmail.com (Rob Herring)
To: linux-arm-kernel@lists.infradead.org
Subject: How to represent active low ARM GIC interrupts, enabled by external inverter?
Date: Mon, 23 Jan 2012 17:12:34 -0600 [thread overview]
Message-ID: <4F1DE962.6030906@gmail.com> (raw)
In-Reply-To: <20120123223315.GB1068@n2100.arm.linux.org.uk>
On 01/23/2012 04:33 PM, Russell King - ARM Linux wrote:
> On Mon, Jan 23, 2012 at 01:18:50PM -0800, Stephen Warren wrote:
>> I'd like guidance on how to model one aspect of Tegra's interrupt
>> structure.
>>
>> Tegra has an interrupt input pin for use by a PMU chip.
>>
>> The PMC HW module within Tegra can optionally invert this signal, but
>> otherwise has no control over it; no interrupt status bits, no masking,
>> etc.
>>
>> The (potentially inverted) signal is then fed into the ARM GIC, which
>> supports level high or rising edge interrupts only.
Stephen, isn't this the same question you posted before except where the
inverter is is different?
http://lists.ozlabs.org/pipermail/devicetree-discuss/2011-December/009880.html
>
> When I originally added the IRQ trigger types to request_irq(), the
> original intention was for these to be specified by the requesting
> driver according to what the chip required, and there to be some kind
> of hook to deal with the inversion which happens on some boards.
>
> However, that was never implemented because there was a far better
> solution: pass this information to the driver via the device resource
> structures, which already have this information defined for PNP
> devices. The driver would then find the IRQ resource which would
> tell it both the number and the IRQ trigger flags to be used.
>
> Some drivers have done this, to cope with differing wiring on boards.
> I don't know if DT supports this though, but I'd suggest that it's
> a solution worth investigating.
>
As my suggestion was the same approach as Russell's.
Rob
next prev parent reply other threads:[~2012-01-23 23:12 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-23 21:18 How to represent active low ARM GIC interrupts, enabled by external inverter? Stephen Warren
2012-01-23 21:18 ` Stephen Warren
[not found] ` <74CDBE0F657A3D45AFBB94109FB122FF178CB81BA2-C7FfzLzN0UxDw2glCA4ptUEOCMrvLtNR@public.gmane.org>
2012-01-23 22:33 ` Russell King - ARM Linux
2012-01-23 22:33 ` Russell King - ARM Linux
[not found] ` <20120123223315.GB1068-l+eeeJia6m9vn6HldHNs0ANdhmdF6hFW@public.gmane.org>
2012-01-23 23:12 ` Rob Herring [this message]
2012-01-23 23:12 ` Rob Herring
[not found] ` <4F1DE962.6030906-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2012-01-23 23:24 ` Stephen Warren
2012-01-23 23:24 ` Stephen Warren
2012-01-23 23:19 ` Stephen Warren
2012-01-23 23:19 ` Stephen Warren
2012-01-23 23:48 ` Rob Herring
2012-01-23 23:48 ` Rob Herring
[not found] ` <4F1DF1CB.20707-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2012-01-25 17:34 ` Stephen Warren
2012-01-25 17:34 ` Stephen Warren
[not found] ` <74CDBE0F657A3D45AFBB94109FB122FF178CB8204C-C7FfzLzN0UxDw2glCA4ptUEOCMrvLtNR@public.gmane.org>
2012-01-25 19:30 ` Grant Likely
2012-01-25 19:30 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F1DE962.6030906@gmail.com \
--to=robherring2-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.